Skip to content

fix(request): add AbortSignal to toWebRequest for client disconnect detection #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LeSingh1 wants to merge 1 commit into
base: v1
Choose a base branch
from
+13 −10
Open

fix(request): add AbortSignal to toWebRequest for client disconnect detection #1418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 13 additions & 10 deletions src/utils/request.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,16 +352,19 @@ export function getRequestURL(
* **NOTE:** This function is not stable and might have edge cases that are not handled properly.
*/
export function toWebRequest(event: H3Event) {
return (
event.web?.request ||
new Request(getRequestURL(event), {
// @ts-ignore Undici option
duplex: "half",
method: event.method,
headers: event.headers,
body: getRequestWebStream(event),
})
);
if (event.web?.request) {
return event.web.request;
}
const controller = new AbortController();
event.node.req.on("close", () => controller.abort());
return new Request(getRequestURL(event), {
// @ts-ignore Undici option
duplex: "half",
method: event.method,
headers: event.headers,
body: getRequestWebStream(event),
signal: controller.signal,
});
}

/**
Expand Down