fix(request): add AbortSignal to toWebRequest for client disconnect detection#1418
Open
LeSingh1 wants to merge 1 commit into
Open
fix(request): add AbortSignal to toWebRequest for client disconnect detection#1418LeSingh1 wants to merge 1 commit into
LeSingh1 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1204
Problem
toWebRequestcreates anew Request()without anAbortSignal. This means downstream code that consumesrequest.signal(e.g. tRPC subscriptions, streaming handlers) can never detect when a client disconnects — the signal stays open forever.Fix
When falling through to
new Request(...), create anAbortController, wire its.abort()toevent.node.req.on("close", ...), and passsignal: controller.signalto theRequestconstructor.When
event.web?.requestis already present (i.e. a native web runtime), it carries its own signal — we return it as-is and skip theAbortControllerentirely.Related