A110: Child Channel Options#529
Open
AgraVator wants to merge 19 commits into
Open
Conversation
markdroth
reviewed
Dec 24, 2025
markdroth
left a comment
markdroth
left a comment
Member
There was a problem hiding this comment.
The overall design looks good, but I think the doc needs work.
My main concern is that we need a much better description of the overall design in a language-agnostic way, rather than just saying that we have a different design for each language. It's true that each language has its own APIs for how per-channel options are set, but the overall goal here is still to have a way to pass a set of options to be used in child channels. The semantics for that should be the same in all languages.
Please let me know if you have any questions. Thanks!
ejona86
reviewed
Jan 15, 2026
christama
approved these changes
Jan 16, 2026
ejona86
reviewed
Jan 20, 2026
ejona86
reviewed
Mar 3, 2026
markdroth
reviewed
Mar 18, 2026
markdroth
left a comment
markdroth
left a comment
Member
There was a problem hiding this comment.
This is looking much better!
Please let me know if you have any questions. Thanks!
markdroth
reviewed
Mar 19, 2026
markdroth
reviewed
Mar 19, 2026
easwars
reviewed
Mar 31, 2026
ejona86
approved these changes
May 14, 2026
easwars
reviewed
Jun 9, 2026
…g to make it clear
easwars
reviewed
Jun 22, 2026
easwars
approved these changes
Jun 23, 2026
markdroth
approved these changes
Jun 26, 2026
markdroth
left a comment
markdroth
left a comment
Member
There was a problem hiding this comment.
Just one small remaining comment, otherwise looks great!
ejona86
reviewed
Jun 30, 2026
AgraVator
added a commit
to grpc/grpc-java
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.