enable child channel plugins#12578
Merged
Merged
Conversation
AgraVator
commented
Dec 23, 2025
Comment on lines
+34
to
+37
| ObjectPool<XdsClient> getOrCreate( | ||
| String target, BootstrapInfo bootstrapInfo, MetricRecorder metricRecorder, | ||
| ManagedChannel parentChannel); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Should this be a generic object instead of ManagedChannel ?
AgraVator
commented
Dec 29, 2025
Comment on lines
+130
to
+149
| return new XdsServerWrapper("0.0.0.0:" + port, delegate, xdsServingStatusListener, | ||
| filterChainSelectorManager, xdsClientPoolFactory, bootstrapOverride, filterRegistry); | ||
| filterChainSelectorManager, xdsClientPoolFactory, bootstrapOverride, filterRegistry, | ||
| this.childChannelConfigurer); |
Contributor
Author
There was a problem hiding this comment.
Why does this not pass the builder object ?
kannanjgithub
previously approved these changes
Jan 6, 2026
ejona86
reviewed
Mar 4, 2026
ejona86
left a comment
ejona86
left a comment
Member
There was a problem hiding this comment.
I know there will be changes based on the gRFC discussion, but here are some things I noticed.
AgraVator
commented
May 26, 2026
ejona86
reviewed
May 26, 2026
kannanjgithub
requested changes
Jun 10, 2026
kannanjgithub
approved these changes
Jun 15, 2026
ejona86
reviewed
Jun 15, 2026
ejona86
left a comment
ejona86
left a comment
Member
There was a problem hiding this comment.
This needs some more work, but I'm comfortable with Kannan reviewing it after the changes from these comments come in (no need to wait for me).
ejona86
reviewed
Jun 16, 2026
ejona86
reviewed
Jun 16, 2026
…ontrol plane channels
…-channel-plugin
…yTest to fix checkstyle
kannanjgithub
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements grpc/proposal#529