CC-NEST-ANNULUS: stamp mixed nest; lock two-arc disc as D4 - #15
Open
grootstebozewolf wants to merge 1 commit into
Open
CC-NEST-ANNULUS: stamp mixed nest; lock two-arc disc as D4#15grootstebozewolf wants to merge 1 commit into
grootstebozewolf wants to merge 1 commit into
Conversation
A mixed stadium nested in CIRCLE_5 is not two certified discs. D4 and R1.7 stay null. A two-arc CompoundCurve disc already certifies and keeps the existing nested-annulus kit. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
This was referenced Aug 16, 2026
grootstebozewolf
marked this pull request as ready for review
August 16, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on
cursor/d5-annulus-tangent-d7aa@ 7370303 (draft PR #13). Does not merge #12, #13, or #7. Does not push tofeature/sfa-curve-rgror master.Sentence
Every circular pair that has a closed form has a kit. Everything else is a named miss and the chordsaw. We will not write a circular noder in this PR.
Choice: stamp, plus a D4 lock
CC-NEST-ANNULUS is a named green null, not a laser. Kit if both operands certify as discs; else stamp. No noder was written.
Stamp (this cell)
Fixture: horizontal stadium
|x|≤2, |y|≤1strictly insideCIRCLE_5.Not a re-run of
CIRCLE_5 \\ CIRCLE_3, notH-ANNULUS-TANGENT, notHALF_SMALL. Mixed CompoundCurve (arcs + segments). 0 nodes.Why every kit misses:
centreRadiusis null)clip()is two-node only, so a 0-node nest returns nullassertNull("CC-NEST-ANNULUS: …")onCircularDiscOverlayandCompoundCurveShellOverlay. Public SUB may chordsaw; that path is approximate, not a laser. Do not punch a stadium-in-disc hole.Kit lock (already D4)
A CompoundCurve of two semicircle arcs vs
CIRCLE_5both certify viaCircularDiscOverlay.centreRadius. That pair already takesnestedAnnulus. This PR does not invent a new noder or a general CompoundCurve annulus. It adds a kit-levelassertNotNullplus CAP/CUP/SUB/XOR exactness (area 16π,isApproximate()=false) so the two-arc encoding cannot silently become R2.Out of scope
Verify
All green after this revision:
CompoundCurveShellOverlayTest24 / 0 (CC-NEST-ANNULUS stamp on R1.7)CircularArcOverlayTest11 / 0 (same named null)CircularDiscOverlayTest12 / 0 (D4 two-arc lock + CC-NEST-ANNULUS stamp + H-ANNULUS-TANGENT)CircularDiscPolygonOverlayTest7 / 0OverlayNGCurvePhase0Test19 / 0OverlayNGCurveRatchetTest44 / 0 (covers two-arc disc is EEEE)OverlayNGCurvePerfGateTest78 / 0 (15% slack)mvn -pl modules/curve test: 589 tests, 0 failuresjts-curvesucceeded