P2.5.6 H-SHELL-N-MIXED overlay kit (Option C, OV-P2 / Bar 2) - #37
Open
grootstebozewolf wants to merge 1 commit into
Open
P2.5.6 H-SHELL-N-MIXED overlay kit (Option C, OV-P2 / Bar 2)#37grootstebozewolf wants to merge 1 commit into
grootstebozewolf wants to merge 1 commit into
Conversation
Option C: consume the P2.2 MIXED interval as a shared edge and return exact CAP/CUP/SUB/XOR. Nodes stay null; the rest-walk of each shell is IN or OUT. SUB/XOR are a bite on the diameter, not a punch. Nested/crossing half-discs stay on HalfDiscOverlay. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
grootstebozewolf
marked this pull request as ready for review
August 16, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #25 (
cursor/p254-tangent-stamp-917c@ 8d1546a). OV-P2 / Bar 2. Option C only. Do not stack on #27 (OverlayNG-for-circles / publicSegmentKindis a dead-end draft). Do not merge this into #7. Does not merge #12 / #13 / #15 / #16 / #17 / #18 / #19 / #20 / #23 / #24 / #25 / #7. Does not push tofeature/sfa-curve-rgror master.Sentence
P2.1–P2.5.4 climbed. N-SS is locked to Option C (
CurveSegmentStringin jts-curve, 0 coreSegmentStringedits). The noder already named MIXED as an edge (P2.2 / #17): H-SHELL-N-MIXED diameter(-1 0)–(1 0). Overlay stillassertNull. This rung consumes that named edge and returns exact CAP / CUP / SUB / XOR.Assembly rule
Shared-edge walk, not a discrete node pair.
CurveSegmentNoder.nodesstaysnull(the overlap is an interval).edgesnames the chord.MixedOverlapOverlaywalks each hole-free CompoundCurve shell from the run's ends, treats the overlap walk as the shared edge, and classifies the rest walk as entirely IN or entirely OUT. CAP / CUP are the inner / outer shells. SUB / XOR splice the two rests into a bite on the diameter (not a punch). A rest that weaves in and out (collinear overlap plus a hidden crossing) staysnull. Nested / crossing half-discs stay onHalfDiscOverlay.The arrangement-walk-on-null-nodes hypothesis was checked and not used as a general faces path:
nodes==nullcan hide a real crossing that the collinear pair aborted (HALF_DISC × HALF_CROSSING_UPPER). The certified rest-walk is the closed form. No snap-rounding, no coreSegmentString/HotPixel/noding.snapround, no densify-then-overlay flagged exact.Not this rung (existing named nulls, unchanged):
TANGENT_LEAVE_ANGLE— N≥3 near-tangent stampCells
isApproximate()=falseTANGENT_LEAVE_ANGLEPins
isApproximate()=falseon MIXED CAP/CUP/SUB/XOR. A chordsaw fallback fails that assert.2 + π/2, CUP =12.5π, SUB/XOR =12.5π − 2 − π/2, reverse SUB empty.AvoidBranchingStatementAsLastInLoop).org.locationtech.jts.operation.overlayng.curve.SegmentKind. NocreateCompoundCurve(CoordinateSequence)polyline lie.What this is not
SegmentKindfeature/sfa-curve-rgr/ PR SFA/SQL-MM curve awareness: Curve rename, arc-aware operations, OverlayNGCurve ratchet (#1195 RGR series) #7 / locationtech masterSegmentString/NoderVerify
All green after this revision:
CurveSegmentStringTest24 / 0 (MIXED overlay + pair-kit faces; pinch / kiss / holed / P2.5.4 stamp unchanged)CompoundCurveShellOverlayTest28 / 0 (testMixedOverlapIsSharedEdgeBiteis the new laser)CircularArcOverlayTest11 / 0CircularDiscOverlayTest12 / 0CircularDiscPolygonOverlayTest7 / 0CircularLineOverlayTest7 / 0OverlayNGCurvePhase0Test19 / 0OverlayNGCurveRatchetTest50 / 0OverlayNGCurvePerfGateTest84 / 0 at 15% slack (MIXED CAP + SUB added)bash dev/check-no-curved.shOKjts-curve