Skip to content

Fix none nollning group test fails - #556

Merged
hannesblaman merged 6 commits into
mainfrom
fix_none_group_tests
Aug 11, 2026
Merged

Fix none nollning group test fails#556
hannesblaman merged 6 commits into
mainfrom
fix_none_group_tests

Conversation

@hannesblaman

Copy link
Copy Markdown
Contributor

Updated one test, added one test and fixed the event signup code to pass the last test

@hannesblaman
hannesblaman marked this pull request as ready for review August 7, 2026 15:51
@hannesblaman hannesblaman self-assigned this Aug 7, 2026
@georgelgeback

Copy link
Copy Markdown
Contributor

Do we want to allow someone to:

  1. Sign up to a nollning event with a certain group
  2. Edit their signup so that they don't have any group associated with the sign up

Allowing this (as we currently do, see: test_update_signup_without_group_name_is_allowed) does conflict a bit with the test_nollning_event_signup_without_group test, since you can achieve a different end state by editing the signup.

@hannesblaman

Copy link
Copy Markdown
Contributor Author

These changes will probably break signup update screen for non-nollning events. This will require small changes on the frontend but I need to test frontend changes some more, and since that probably won't be an issue until after nollning I will not prioritize this right now (next week maybe). This should work for now.

@georgelgeback

Copy link
Copy Markdown
Contributor

Changed it so that we use exclue_unset=True which means any field not sent by the frontend will be left alone. Added some more tests to ensure this works (only checked priority because that required the least changes to tests and group name is already kinda checked afaik). We did need frontend changes to make clearing priority from signup card possible: fsek/WWW-Web#320

@georgelgeback georgelgeback left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hannesblaman
hannesblaman merged commit 91f1c0e into main Aug 11, 2026
1 check passed
@georgelgeback
georgelgeback deleted the fix_none_group_tests branch August 11, 2026 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants