Skip to content

Update cstruct color imports - #1740

Merged
Schamper merged 4 commits into
fox-it:mainfrom
JSCU-CNI:cstruct-color-imports
Apr 30, 2026
Merged

Update cstruct color imports#1740
Schamper merged 4 commits into
fox-it:mainfrom
JSCU-CNI:cstruct-color-imports

Conversation

@JSCU-CNI

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread dissect/target/tools/qfind.py Outdated
@Miauwkeru

Copy link
Copy Markdown
Contributor

could you also update the pyproject.toml?

diff --git a/pyproject.toml b/pyproject.toml
index 0a69d474..cd2ea0a6 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -26,7 +26,7 @@ classifiers = [
 ]
 dependencies = [
     "defusedxml",
-    "dissect.cstruct>=4,<5",
+    "dissect.cstruct>=4.8.dev7,<5",
     "dissect.database>=1.1,<2",
     "dissect.eventlog>=3,<4",
     "dissect.evidence>=3.13,<4",
@@ -83,7 +83,7 @@ dev = [
     "dissect.cim[dev]>=3.0.dev,<4.0.dev",
     "dissect.clfs[dev]>=1.0.dev,<2.0.dev",
     "dissect.cramfs[dev]>=1.0.dev,<2.0.dev",
-    "dissect.cstruct>=4.0.dev,<5.0.dev",
+    "dissect.cstruct>=4.8.dev7,<5.0.dev",
     "dissect.database[dev]>=1.1,<2.0.dev",
     "dissect.etl[dev]>=3.0.dev,<4.0.dev",
     "dissect.eventlog[dev]>=3.0.dev,<4.0.dev",

@JSCU-CNI
JSCU-CNI requested a review from Schamper April 30, 2026 09:16
@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.27%. Comparing base (22e7a81) to head (3e11b4f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1740   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files         403      403           
  Lines       35378    35378           
=======================================
  Hits        28754    28754           
  Misses       6624     6624           
Flag Coverage Δ
unittests 81.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@codspeed-hq

codspeed-hq Bot commented Apr 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing JSCU-CNI:cstruct-color-imports (3e11b4f) with main (14c052c)

Open in CodSpeed

@Schamper
Schamper merged commit 8cadf15 into fox-it:main Apr 30, 2026
18 of 21 checks passed
@JSCU-CNI
JSCU-CNI deleted the cstruct-color-imports branch April 30, 2026 09:47
yunzheng pushed a commit that referenced this pull request Apr 30, 2026
twiggler pushed a commit to twiggler/dissect-monorepo-test that referenced this pull request May 26, 2026
twiggler pushed a commit to twiggler/dissect-monorepo-test that referenced this pull request Jun 4, 2026
twiggler pushed a commit to twiggler/dissect-monorepo-test that referenced this pull request Jun 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants