Update cstruct.util colours - #1739
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1739 +/- ##
=======================================
Coverage 81.27% 81.27%
=======================================
Files 403 403
Lines 35378 35378
=======================================
Hits 28754 28754
Misses 6624 6624
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
|
||
| if not NO_COLOR: | ||
| header = utils.COLOR_WHITE + header + utils.COLOR_NORMAL | ||
| header = utils.COLOR_WHITE + header + utils.COLOR_CLEAR_BOLD |
There was a problem hiding this comment.
| header = utils.COLOR_WHITE + header + utils.COLOR_CLEAR_BOLD | |
| header = utils.COLOR_WHITE + header + utils.COLOR_CLEAR |
Maybe just use this one, as it's not personally clear to me why the _BOLD variant should be used. I actually remove the BOLD variant in this PR: fox-it/dissect.cstruct#156
There was a problem hiding this comment.
I used the _BOLD variant as it had the same value as COLOR_NORMAL, so it just maintained what was there before. I have no issue changing it to COLOR_CLEAR, shall I just change everything immediately so we don't have a similar issue when that pr gets merged?
|
#1740 also changes the other colors so maybe let that one be leading? |
Sure, then I'll close this one. I'll request them to update the pyprojects.toml file |
No description provided.