Skip to content

Update cstruct.util colours - #1739

Closed
Miauwkeru wants to merge 1 commit into
mainfrom
update-cstruct-crash
Closed

Update cstruct.util colours#1739
Miauwkeru wants to merge 1 commit into
mainfrom
update-cstruct-crash

Conversation

@Miauwkeru

Copy link
Copy Markdown
Contributor

No description provided.

@codecov

codecov Bot commented Apr 30, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.27%. Comparing base (22e7a81) to head (6a54434).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1739   +/-   ##
=======================================
  Coverage   81.27%   81.27%           
=======================================
  Files         403      403           
  Lines       35378    35378           
=======================================
  Hits        28754    28754           
  Misses       6624     6624           
Flag Coverage Δ
unittests 81.27% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


if not NO_COLOR:
header = utils.COLOR_WHITE + header + utils.COLOR_NORMAL
header = utils.COLOR_WHITE + header + utils.COLOR_CLEAR_BOLD

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
header = utils.COLOR_WHITE + header + utils.COLOR_CLEAR_BOLD
header = utils.COLOR_WHITE + header + utils.COLOR_CLEAR

Maybe just use this one, as it's not personally clear to me why the _BOLD variant should be used. I actually remove the BOLD variant in this PR: fox-it/dissect.cstruct#156

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the _BOLD variant as it had the same value as COLOR_NORMAL, so it just maintained what was there before. I have no issue changing it to COLOR_CLEAR, shall I just change everything immediately so we don't have a similar issue when that pr gets merged?

@codspeed-hq

codspeed-hq Bot commented Apr 30, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 16 untouched benchmarks


Comparing update-cstruct-crash (6a54434) with main (22e7a81)

Open in CodSpeed

@Schamper

Copy link
Copy Markdown
Member

#1740 also changes the other colors so maybe let that one be leading?

@Miauwkeru

Copy link
Copy Markdown
Contributor Author

#1740 also changes the other colors so maybe let that one be leading?

Sure, then I'll close this one. I'll request them to update the pyprojects.toml file

@Miauwkeru Miauwkeru closed this Apr 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants