Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
- Fixed an issue in `apps:create` where App Store ID was always prompted for even when unnecessary.
- Add `functions:lifecycle:list` and `functions:lifecycle:run` commands to view and run
lifecycle hooks in isolation.
- Fixed `dataconnect:execute` command help text. The right env var should be FIREBASE_DATA_CONNECT_EMULATOR_HOST, with an underscore between DATA and CONNECT.
2 changes: 1 addition & 1 deletion src/commands/dataconnect-execute.ts
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@

export const command = new Command("dataconnect:execute [file] [operationName]")
.description(
"execute a SQL Connect query or mutation. If FIREBASE_DATACONNECT_EMULATOR_HOST is set (such as during 'firebase emulator:exec', executes against the emulator instead.",
"execute a SQL Connect query or mutation. If FIREBASE_DATA_CONNECT_EMULATOR_HOST is set (such as during 'firebase emulator:exec', executes against the emulator instead.",
Comment thread
yuchenshi marked this conversation as resolved.
Outdated
)
.option(
"--service <serviceId>",
Expand Down Expand Up @@ -256,7 +256,7 @@
},
);

function parseJsonObject(json: string, subject: string): Record<string, any> {

Check warning on line 259 in src/commands/dataconnect-execute.ts

View workflow job for this annotation

GitHub Actions / lint (24)

Unexpected any. Specify a different type
let obj: unknown;
try {
obj = JSON.parse(json || "{}") as unknown;
Expand All @@ -268,7 +268,7 @@
return obj;
}

async function literalOrFile(arg: any, subject: string): Promise<string> {

Check warning on line 271 in src/commands/dataconnect-execute.ts

View workflow job for this annotation

GitHub Actions / lint (24)

Unexpected any. Specify a different type
let str = arg as string | undefined;
if (!str) {
return "";
Expand Down
Loading