-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Fix env var name in dataconnect:execute help text. #10771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
yuchenshi
merged 6 commits into
main
from
spr/yuchenshi/fix-env-var-name-in-dataconnectexecute-help-text
Jul 14, 2026
+7
−1
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
68a6ddb
[spr] initial version
yuchenshi 2420b46
Update src/commands/dataconnect-execute.ts
yuchenshi cd3486e
Merge branch 'main' into spr/yuchenshi/fix-env-var-name-in-dataconnec…
yuchenshi b2497dd
Merge branch 'main' into spr/yuchenshi/fix-env-var-name-in-dataconnec…
yuchenshi 3ddc41c
Use constant for the env var name
yuchenshi ad3342c
Merge branch 'main' into spr/yuchenshi/fix-env-var-name-in-dataconnec…
yuchenshi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,4 @@ | ||
| - Fixed an issue in `apps:create` where App Store ID was always prompted for even when unnecessary. | ||
| - Add `functions:lifecycle:list` and `functions:lifecycle:run` commands to view and run | ||
| lifecycle hooks in isolation. | ||
| - Fixed `dataconnect:execute` command help text. The right env var should be FIREBASE_DATA_CONNECT_EMULATOR_HOST, with an underscore between DATA and CONNECT. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.