Fix env var name in dataconnect:execute help text.#10771
Merged
yuchenshi merged 6 commits intoJul 14, 2026
Merged
Conversation
Created using spr 1.3.6-beta.1
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request corrects the environment variable name to FIREBASE_DATA_CONNECT_EMULATOR_HOST in the dataconnect:execute command description and the changelog. The reviewer identified a missing closing parenthesis in the updated description string and provided a code suggestion to fix it.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
…texecute-help-text
joehan
approved these changes
Jul 10, 2026
joehan
left a comment
joehan
left a comment
Member
There was a problem hiding this comment.
Lgtm, but maybe we should make this a constant
Member
Author
Done but note that the name of the constant is the source of the the confusion in the first place. I'm not sure this is better. |
…texecute-help-text
yuchenshi
deleted the
spr/yuchenshi/fix-env-var-name-in-dataconnectexecute-help-text
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See CHANGELOG diff.
Scenarios Tested
See Sample Commands.
Sample Commands
firebase dataconnect:execute --help