-
Notifications
You must be signed in to change notification settings - Fork 617
tenable_io: replace scan details endpoint and remap schema #20347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,11 +1,11 @@ | ||
| { | ||
| "@timestamp": "2018-12-31T22:27:58.599Z", | ||
| "agent": { | ||
| "ephemeral_id": "f945f2c2-fbaf-4b93-b6ca-7d51e6a0706d", | ||
| "id": "a0570906-16fc-4c38-821f-7c3aa6ed04bb", | ||
| "name": "docker-fleet-agent", | ||
| "ephemeral_id": "e923234c-5974-4b16-9bcb-8a239b43daf3", | ||
| "id": "936d2df1-19df-44ad-a3bb-57f1db8147c9", | ||
| "name": "elastic-agent-10653", | ||
| "type": "filebeat", | ||
| "version": "8.12.0" | ||
| "version": "9.4.3" | ||
| }, | ||
| "cloud": { | ||
| "availability_zone": "12", | ||
|
|
@@ -18,34 +18,33 @@ | |
| }, | ||
| "data_stream": { | ||
| "dataset": "tenable_io.asset", | ||
| "namespace": "ep", | ||
| "namespace": "37407", | ||
| "type": "logs" | ||
| }, | ||
| "ecs": { | ||
| "version": "8.11.0" | ||
| }, | ||
| "elastic_agent": { | ||
| "id": "a0570906-16fc-4c38-821f-7c3aa6ed04bb", | ||
| "id": "936d2df1-19df-44ad-a3bb-57f1db8147c9", | ||
| "snapshot": false, | ||
| "version": "8.12.0" | ||
| "version": "9.4.3" | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please regenerate the sample events with a 8.19.0 stack so that they match the behaviour of the stated minimum version. This will revert the scalar to array changes that we are seeing in the samples, for example |
||
| }, | ||
| "event": { | ||
| "agent_id_status": "verified", | ||
| "category": [ | ||
| "host" | ||
| ], | ||
| "dataset": "tenable_io.asset", | ||
| "ingested": "2024-04-02T09:13:00Z", | ||
| "ingested": "2026-07-24T08:46:22Z", | ||
| "kind": "state", | ||
| "module": "tenable_io", | ||
| "original": "{\"acr_score\":\"3\",\"agent_names\":[],\"agent_uuid\":\"22\",\"aws_availability_zone\":null,\"aws_ec2_instance_ami_id\":\"12\",\"aws_ec2_instance_group_name\":null,\"aws_ec2_instance_id\":\"12\",\"aws_ec2_instance_state_name\":null,\"aws_ec2_instance_type\":null,\"aws_ec2_name\":null,\"aws_ec2_product_code\":null,\"aws_owner_id\":\"44\",\"aws_region\":null,\"aws_subnet_id\":null,\"aws_vpc_id\":null,\"azure_resource_id\":\"12\",\"azure_vm_id\":\"12\",\"bigfix_asset_id\":null,\"bios_uuid\":\"33\",\"created_at\":\"2017-12-31T20:40:44.535Z\",\"deleted_at\":\"2017-12-31T20:40:44.535Z\",\"deleted_by\":\"user\",\"exposure_score\":\"721\",\"first_scan_time\":\"2017-12-31T20:40:23.447Z\",\"first_seen\":\"2017-12-31T20:40:23.447Z\",\"fqdns\":[\"example.com\"],\"gcp_instance_id\":\"12\",\"gcp_project_id\":\"12\",\"gcp_zone\":\"12\",\"has_agent\":false,\"has_plugin_results\":true,\"hostnames\":[],\"id\":\"95c2725c-7298-4a44-8a1d-63131ca3f01f\",\"installed_software\":[\"cpe:/a:test:xyz:12.8\",\"cpe:/a:test:abc:7.7.3\",\"cpe:/a:test:pqr:6.9\",\"cpe:/a:test:xyz\"],\"ipv4s\":[\"89.160.20.112\"],\"ipv6s\":[],\"last_authenticated_scan_date\":\"2017-12-31T20:40:44.535Z\",\"last_licensed_scan_date\":\"2018-12-31T22:27:52.869Z\",\"last_scan_id\":\"00283024-afee-44ea-b467-db5a6ed9fd50ab8f7ecb158c480e\",\"last_scan_time\":\"2018-03-31T22:27:52.869Z\",\"last_schedule_id\":\"72284901-7c68-42b2-a0c4-c1e75568849df60557ee0e264228\",\"last_seen\":\"2018-12-31T22:27:52.869Z\",\"mac_addresses\":[],\"manufacturer_tpm_ids\":[],\"mcafee_epo_agent_guid\":null,\"mcafee_epo_guid\":null,\"netbios_names\":[],\"network_interfaces\":[{\"fqdns\":[\"example.com\"],\"ipv4s\":[\"89.160.20.112\",\"81.2.69.144\"],\"ipv6s\":[\"2a02:cf40::\"],\"mac_addresses\":[\"00-00-5E-00-53-00\",\"00-00-5E-00-53-FF\"],\"name\":\"test.0.1234\"}],\"operating_systems\":[],\"qualys_asset_ids\":[],\"qualys_host_ids\":[],\"servicenow_sysid\":null,\"sources\":[{\"first_seen\":\"2017-12-31T20:40:23.447Z\",\"last_seen\":\"2018-12-31T22:27:52.869Z\",\"name\":\"TEST_SCAN\"}],\"ssh_fingerprints\":[],\"symantec_ep_hardware_keys\":[],\"system_types\":[],\"tags\":[{\"added_at\":\"2018-12-31T14:53:13.817Z\",\"added_by\":\"ac2e7ef6-fac9-47bf-9170-617331322885\",\"key\":\"Geographic Area\",\"uuid\":\"47e7f5f6-1013-4401-a705-479bfadc7826\",\"value\":\"APAC\"}],\"terminated_at\":\"2017-12-31T20:40:44.535Z\",\"terminated_by\":\"user\",\"updated_at\":\"2018-12-31T22:27:58.599Z\"}", | ||
| "type": [ | ||
| "info" | ||
| ] | ||
| }, | ||
| "host": { | ||
| "domain": [ | ||
| "example.com" | ||
| ], | ||
| "domain": "example.com", | ||
| "id": "95c2725c-7298-4a44-8a1d-63131ca3f01f", | ||
| "ip": [ | ||
| "89.160.20.112" | ||
|
|
@@ -96,9 +95,7 @@ | |
| "exposure_score": 721, | ||
| "first_scan_time": "2017-12-31T20:40:23.447Z", | ||
| "first_seen": "2017-12-31T20:40:23.447Z", | ||
| "fqdns": [ | ||
| "example.com" | ||
| ], | ||
| "fqdns": "example.com", | ||
| "gcp": { | ||
| "instance_id": "12", | ||
| "project_id": "12", | ||
|
|
@@ -113,53 +110,41 @@ | |
| "cpe:/a:test:pqr:6.9", | ||
| "cpe:/a:test:xyz" | ||
| ], | ||
| "ipv4s": [ | ||
| "89.160.20.112" | ||
| ], | ||
| "ipv4s": "89.160.20.112", | ||
| "last_authenticated_scan_date": "2017-12-31T20:40:44.535Z", | ||
| "last_licensed_scan_date": "2018-12-31T22:27:52.869Z", | ||
| "last_scan_id": "00283024-afee-44ea-b467-db5a6ed9fd50ab8f7ecb158c480e", | ||
| "last_scan_time": "2018-03-31T22:27:52.869Z", | ||
| "last_schedule_id": "72284901-7c68-42b2-a0c4-c1e75568849df60557ee0e264228", | ||
| "last_seen": "2018-12-31T22:27:52.869Z", | ||
| "network_interfaces": [ | ||
| { | ||
| "fqdns": [ | ||
| "example.com" | ||
| ], | ||
| "ipv4s": [ | ||
| "89.160.20.112", | ||
| "81.2.69.144" | ||
| ], | ||
| "ipv6s": [ | ||
| "2a02:cf40::" | ||
| ], | ||
| "mac_addresses": [ | ||
| "00-00-5E-00-53-00", | ||
| "00-00-5E-00-53-FF" | ||
| ], | ||
| "name": "test.0.1234" | ||
| } | ||
| ], | ||
| "sources": [ | ||
| { | ||
| "first_seen": "2017-12-31T20:40:23.447Z", | ||
| "last_seen": "2018-12-31T22:27:52.869Z", | ||
| "name": "TEST_SCAN" | ||
| } | ||
| ], | ||
| "tags": [ | ||
| { | ||
| "added_at": "2018-12-31T14:53:13.817Z", | ||
| "added_by": "ac2e7ef6-fac9-47bf-9170-617331322885", | ||
| "key": "Geographic Area", | ||
| "uuid": "47e7f5f6-1013-4401-a705-479bfadc7826", | ||
| "value": "APAC" | ||
| } | ||
| ], | ||
| "network_interfaces": { | ||
| "fqdns": "example.com", | ||
| "ipv4s": [ | ||
| "89.160.20.112", | ||
| "81.2.69.144" | ||
| ], | ||
| "ipv6s": "2a02:cf40::", | ||
| "mac_addresses": [ | ||
| "00-00-5E-00-53-00", | ||
| "00-00-5E-00-53-FF" | ||
| ], | ||
| "name": "test.0.1234" | ||
| }, | ||
| "sources": { | ||
| "first_seen": "2017-12-31T20:40:23.447Z", | ||
| "last_seen": "2018-12-31T22:27:52.869Z", | ||
| "name": "TEST_SCAN" | ||
| }, | ||
| "tags": { | ||
| "added_at": "2018-12-31T14:53:13.817Z", | ||
| "added_by": "ac2e7ef6-fac9-47bf-9170-617331322885", | ||
| "key": "Geographic Area", | ||
| "uuid": "47e7f5f6-1013-4401-a705-479bfadc7826", | ||
| "value": "APAC" | ||
| }, | ||
| "terminated_at": "2017-12-31T20:40:44.535Z", | ||
| "terminated_by": "user", | ||
| "updated_at": "2018-12-31T22:27:58.599Z" | ||
| } | ||
| } | ||
| } | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changelog entry is marked as
type: bugfixunder4.13.0(minor), but this change removes the published WASscan_details.*fields and replaces them with the VM schema. Since it introduces a breaking schema change, it should be classified as abreaking-changeand released as a major version.If it's truly a bugfix, it should be a patch release (e.g., 4.12.1). As it stands,
4.13.0withtype: bugfixis inconsistent.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a breaking change since the previous code never worked. However, yes, this should bump patch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just thought it is a change it worths a minor version bump because of the size of the change. If you both think it should be a patch version despite the changes it includes that's ok for me.