tenable_io: replace scan details endpoint and remap schema#20347
tenable_io: replace scan details endpoint and remap schema#20347chemamartinez wants to merge 2 commits into
Conversation
✅ Elastic Docs Style Checker (Vale)No issues found on modified lines! The Vale linter checks documentation changes against the Elastic Docs style guide. To use Vale locally or report issues, refer to Elastic style guide for Vale. |
|
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
|
✅ All changelog entries have the correct PR link. |
|
No issues across the latest commits 7f25523.
🤖 AI-Generated Review | Vera Review Bot | 📚 Knowledge base: integration-skills
|
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
| - name: scanner_start | ||
| type: keyword | ||
| description: The scan's start time, if the scan is imported. | ||
| - name: scanner_end | ||
| type: keyword | ||
| description: The scan's end time, if the scan is imported. |
There was a problem hiding this comment.
Why are both fields defined as keyword? Based on their descriptions, they appear to represent dates, so they should be mapped as date fields, with appropriate date processors on them.
| - version: "4.13.0" | ||
| changes: | ||
| - description: Replace the scan details endpoint with GET /scans/{id} and remap the scan_details fields to the standard VM scan-details schema. | ||
| type: bugfix |
There was a problem hiding this comment.
The changelog entry is marked as type: bugfix under 4.13.0 (minor), but this change removes the published WAS scan_details.* fields and replaces them with the VM schema. Since it introduces a breaking schema change, it should be classified as a breaking-change and released as a major version.
If it's truly a bugfix, it should be a patch release (e.g., 4.12.1). As it stands, 4.13.0 with type: bugfix is inconsistent.
| "high": 3, | ||
| "host_id": 5, | ||
| "host_index": 0, | ||
| "hostname": "192.0.2.57", |
There was a problem hiding this comment.
VM schema adds hosts[].hostname and info.targets that often hold IPs. Other streams in this CDR package append to related.ip; can we also them to realted.ip?
| fields: | ||
| - name: asset_id | ||
| type: long | ||
| - name: host_id |
There was a problem hiding this comment.
The comphosts object is missing descriptions for its leaf fields. To keep the schema consistent, could we mirror the field descriptions from hosts (if not available for comphosts) onto the corresponding comphosts leaf fields?
Proposed commit message
Checklist
changelog.ymlfile.Related issues