Skip to content

Fix spurious 'default construction is disabled' error for class #23393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ntrel wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

Fix spurious 'default construction is disabled' error for class #23393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion compiler/src/dmd/expressionsem.d
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4541,7 +4541,8 @@ private bool functionParameters(Loc loc, Scope* sc,
{
// Look for misaligned pointer, etc., in @safe mode
err |= checkUnsafeAccess(sc, arg, false, true);
err |= checkDefCtor(arg.loc, t); // t must be default constructible
if (!t.isClassHandle())

@dkorpel dkorpel Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (!t.isClassHandle())
if (!t.baseElemOf().isTypeClass())

So it also works with enums and static arrays

enum E : Client { a = null }
void sinkArr(out Client[3] r) {}
void sinkEnumArr(out E[3] r) {}

err |= checkDefCtor(arg.loc, t); // t must be default constructible
}
arg = arg.toLvalue(sc, "create `out` parameter from");
}
Expand Down
9 changes: 9 additions & 0 deletions compiler/test/compilable/class_struct_disable_default.d
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
// https://github.com/dlang/dmd/issues/23392
struct Parser { @disable this(); this(int) {} }
class Client { Parser parser; this() { parser = Parser(0); } }
void sink(out Client r) {}
void main() {

@thewilsonator thewilsonator Jul 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

compilable test should not contain a main, rename test.

Client c;
// passing c just sets it to null, so no @disable error needed
sink(c);
}
Loading