Fix spurious 'default construction is disabled' error for class#23393
Open
ntrel wants to merge 1 commit into
Open
Fix spurious 'default construction is disabled' error for class#23393ntrel wants to merge 1 commit into
ntrel wants to merge 1 commit into
Conversation
Fixes dlang#23392. Bug introduced in dlang#23212.
dkorpel
reviewed
Jul 13, 2026
| // Look for misaligned pointer, etc., in @safe mode | ||
| err |= checkUnsafeAccess(sc, arg, false, true); | ||
| err |= checkDefCtor(arg.loc, t); // t must be default constructible | ||
| if (!t.isClassHandle()) |
Contributor
There was a problem hiding this comment.
Suggested change
| if (!t.isClassHandle()) | |
| if (!t.baseElemOf().isTypeClass()) |
So it also works with enums and static arrays
enum E : Client { a = null }
void sinkArr(out Client[3] r) {}
void sinkEnumArr(out E[3] r) {}
Contributor
|
Thanks for investigating this so quickly! |
| struct Parser { @disable this(); this(int) {} } | ||
| class Client { Parser parser; this() { parser = Parser(0); } } | ||
| void sink(out Client r) {} | ||
| void main() { |
Contributor
There was a problem hiding this comment.
compilable test should not contain a main, rename test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23392.
Bug introduced in #23212.