Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .github/workflows/ci-main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -579,6 +579,15 @@ jobs:
name: Build Determinism
runs-on: ubuntu-latest
needs: [build-ic, bazel-test-all]
# Run even when `bazel-test-all` fails: its test failures happen *after*
# its build succeeded, its execution logs were uploaded (the bazel action
# uploads them on failure too) and — on release builds — the artifacts
# were already published to the CDN. Without this condition a single
# failing/flaky test silently skipped the determinism check while the
# artifacts still shipped. `build-ic` still has to succeed: it produces the
# no-cache side of the comparison (and is skipped on merge_group, where
# there is nothing to compare).
if: ${{ !cancelled() && needs.build-ic.result == 'success' }}
Comment thread
basvandijk marked this conversation as resolved.
steps:
- name: Download execution logs (cache)
uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1
Expand Down
Loading