fix: don't skip Build Determinism when bazel-test-all tests fail - #11091
Open
basvandijk wants to merge 2 commits into
Open
fix: don't skip Build Determinism when bazel-test-all tests fail#11091basvandijk wants to merge 2 commits into
basvandijk wants to merge 2 commits into
Conversation
The build-determinism job compares per-artifact digests between the remote-cache-enabled Bazel Test All build and the no-cache Build IC build. It had `needs: [build-ic, bazel-test-all]` with no `if:`, so any test failure in Bazel Test All skipped it — even though by that point the job's build step had succeeded, its execution logs had been uploaded (the bazel action uploads them on failure too) and, on release builds, the artifacts had already been published to the CDN by the "Upload artifacts" step. That is exactly how 9e29205 and f18ab1c shipped to the CDN with the determinism check silently skipped: both master pushes had ordinary test failures, so the pcre2-sys non-reproducibility introduced by 9e29205 (fixed in #11090) sailed through unnoticed and only surfaced when repro-check failed on a dev machine. Run the job whenever the run isn't cancelled and build-ic succeeded (build-ic produces the no-cache side of the comparison and is skipped on merge_group, where there is nothing to compare — that behavior is unchanged). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CI workflow so the Build Determinism gate still runs when Bazel Test All fails during its test phase, preventing flaky/failing tests from silently skipping determinism verification for artifacts that may already be published.
Changes:
- Adds a job-level
if:guard to run Build Determinism when the workflow isn’t cancelled andbuild-icsucceeded, regardless ofbazel-test-all’s final result. - Documents the rationale in-line (why Bazel test failures previously caused determinism checks to be skipped while artifacts could still ship).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
basvandijk
commented
Aug 10, 2026
nmattia
approved these changes
Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
build-determinism(which compares per-artifact digests between the remote-cache-enabled Bazel Test All build and the no-cache Build IC build) declaredneeds: [build-ic, bazel-test-all]with noif:— so any test failure in Bazel Test All skipped it. By the time tests run in that job, its build step has succeeded, its execution logs are uploaded (the.github/actions/bazelaction uploads themif: success() || failure()), and on release builds the artifacts have already been published to the CDN by the "Upload artifacts" step.Net effect: an ordinary flaky/failing test disables the determinism gate for artifacts that still ship. That's exactly how
9e2920593eandf18ab1c843reached the CDN with the check silently skipped (both master pushes had test failures; verified via the jobs API —Build Determinism: skippedon both runs). The pcre2-sys non-reproducibility introduced by9e2920593e(fixed in #11090) went unnoticed untilrepro-checkfailed on a dev machine.Fix
build-icmust still have succeeded: it produces the no-cache side of the comparison, and it is skipped onmerge_groupruns — where the determinism job stays skipped exactly as before.Found while root-causing the GuestOS reproducibility regression (see #11090 for the full analysis).
🤖 Generated with Claude Code