Skip to content

input: do not explicitly prohibit 'admin' as a password. #4831

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
richardhenwood-dell wants to merge 2 commits into
base: staging
Choose a base branch
from
+2 −2
Open

input: do not explicitly prohibit 'admin' as a password. #4831

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7a59ea6
input: allow admin as a password
richardhenwood-dell Jul 10, 2026
c88c3ae
removed redundant guidance about 'admin'
richardhenwood-dell Jul 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions common/library/module_utils/input_validation/schema/credential_rules.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,8 +105,8 @@
"s3_secret_key": {
"minLength": 8,
"maxLength": 128,
"pattern": "^(?!admin$)[^\\\\'\"]+$",
"description": "S3 Secret Key for storage backend (MinIO password or Dell PowerScale S3 Secret Key). Should not be kept 'admin'. Length must be between 8 and 128 characters and must not contain backslashes (\\), single quotes ('), or double quotes (\\\")."
"pattern": "^[^\\\\\\-'\"]+$",

@abhishek-sa1 abhishek-sa1 Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this change required? can you modify description as well

@abhishek-sa1 abhishek-sa1 Jul 13, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

requires a validation having admin as password as admin for minio flow

@richardhenwood-dell richardhenwood-dell Jul 13, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this feedback. I had a chat with @priti-parate - there appears to be a historical reason why 'admin' was prohibited. If we can discover that and it is still relevant than I think this PR can be changed: line 109 s/Should/Must/.

let's see if we can unearth weather 'admin' is prohibited by a rule, or not :)

@abhishek-sa1 abhishek-sa1 Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. can you update error message instead of the rule

@richardhenwood-dell richardhenwood-dell Jul 14, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, I've updated the text to remove the info about 'admin'. 'admin' cannot be used for at least one reason: it is less than 8 characters. We don't need to call it out specifically.

However, now the title of this PR is incorrect. I will update that.

"description": "S3 Secret Key for storage backend (MinIO password or Dell PowerScale S3 Secret Key). Length must be between 8 and 128 characters and must not contain backslashes (\\), single quotes ('), or double quotes (\\\")."
},
"s3_access_id": {
"minLength": 4,
Expand Down
Loading