input: allow admin as a password#4831
Open
richardhenwood-dell wants to merge 1 commit into
Open
Conversation
fixes dell#4830 Signed-off-by: Richard Henwood <richard.henwood@dell.com>
| "minLength": 8, | ||
| "maxLength": 128, | ||
| "pattern": "^(?!admin$)[^\\\\'\"]+$", | ||
| "pattern": "^[^\\\\\\-'\"]+$", |
Collaborator
There was a problem hiding this comment.
is this change required? can you modify description as well
Collaborator
There was a problem hiding this comment.
requires a validation having admin as password as admin for minio flow
Collaborator
Author
There was a problem hiding this comment.
thanks for this feedback. I had a chat with @priti-parate - there appears to be a historical reason why 'admin' was prohibited. If we can discover that and it is still relevant than I think this PR can be changed: line 109 s/Should/Must/.
let's see if we can unearth weather 'admin' is prohibited by a rule, or not :)
Collaborator
There was a problem hiding this comment.
looks good. can you update error message instead of the rule
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
input: allow admin as a password
Fixes #4830