Kill commerceguys/zone - #106
Closed
jahidulpabelislam wants to merge 1 commit into
Closed
Conversation
jahidulpabelislam
force-pushed
the
kill-zone
branch
4 times, most recently
from
June 4, 2026 22:35
c76608a to
560b492
Compare
Collaborator
|
Would it be worth porting the unit tests at https://github.com/commerceguys/zone/blob/master/tests/Repository/ZoneRepositoryTest.php too? |
Merged
jahidulpabelislam
force-pushed
the
kill-zone
branch
2 times, most recently
from
June 15, 2026 18:44
e2c296e to
ad528dc
Compare
jahidulpabelislam
force-pushed
the
kill-zone
branch
from
June 15, 2026 18:44
ad528dc to
241fdff
Compare
jahidulpabelislam
marked this pull request as ready for review
July 6, 2026 13:53
Contributor
Author
|
@dmnc This is ready. Think it is a 2.x release though? |
Contributor
Author
|
Closing in favour in one bigger change - #108 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
commerceguys/zoneis dead, As zone stuff is incommerceguys/addressing- the only thing missing is the Repository, I have added here now.Closes #101.
Likely this is a breaking change release as the type/class for Zone is different if usage has custom resolvers or repositories.