Explict null params - #105
Merged
Merged
Conversation
jahidulpabelislam
force-pushed
the
explicit-nulls
branch
from
June 4, 2026 22:35
2d452ef to
dc0c8f3
Compare
Collaborator
|
Given that in the not too distant future explicit nullable types will likely be dropped, I think, like many other packages, it is acceptable to move to 7.1+. |
dmnc
approved these changes
Jun 15, 2026
dmnc
left a comment
dmnc
left a comment
Collaborator
There was a problem hiding this comment.
Regrettable but I think this is now inevitable.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix some deprecated warnings for PHP8.4 - had to bump min req to 7.1 to add the null type hint.
https://github.com/commerceguys/zone is throwing 2 but is archived 😢... but now have #106 in the works.