wire-local-setup: support wire-sysio's renamed OPP bundle generator (.fish → .sh) - #3
Open
valthon wants to merge 1 commit into
Open
wire-local-setup: support wire-sysio's renamed OPP bundle generator (.fish → .sh)#3valthon wants to merge 1 commit into
valthon wants to merge 1 commit into
Conversation
wire-sysio renamed libraries/opp/tools/scripts/generate-opp-bundles.fish to generate-opp-bundles.sh on master (8ce1b9bf90, 2026-07-08). The setup script still called the .fish name unconditionally, so any e2e image build against a post-rename wire-sysio ref failed at the OPP-bundle step: wire-local-setup.bash: line 479: ./scripts/generate-opp-bundles.fish: No such file or directory Prefer the .sh name and fall back to .fish, so both current mainlines and pre-rename branches (including the Dockerfile's current default, feature/opp-part2) keep building. Verified: wire-e2e-env built green against wire-sysio@master with this change (previously failed at the bundle step). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K4FBvbwEeTj7ByeJzjehbQ
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
wire-local-setup.bashcalled./scripts/generate-opp-bundles.fishunconditionally. wire-sysio renamed that script togenerate-opp-bundles.shonmaster(8ce1b9bf90, 2026-07-08), so anywire-e2e-envimage build against a post-rename wire-sysio ref died at the OPP-bundle step:This change prefers
generate-opp-bundles.shand falls back to.fish, so both current mainlines and pre-rename branches (including the Dockerfile's current default,feature/opp-part2) keep building.Verification
docker buildx build -f e2e-build.DockerfilewithGIT_BRANCH_SYSIO=masterfailed at the bundle step with the error above (~47 min in).wire-e2e-envtagged;nodeopbuilt at/opt/wire/build/wire-sysio/build/debug/bin/nodeop).Related
A follow-up PR refreshes the Dockerfile's stale
GIT_BRANCH_*defaults to the current manifest mainlines; this PR should merge first (it keeps the argless default build working in every ordering).🤖 Generated with Claude Code
https://claude.ai/code/session_01K4FBvbwEeTj7ByeJzjehbQ