e2e-build: refresh stale GIT_BRANCH_* defaults to the manifest mainlines - #4
Open
valthon wants to merge 1 commit into
Open
e2e-build: refresh stale GIT_BRANCH_* defaults to the manifest mainlines#4valthon wants to merge 1 commit into
valthon wants to merge 1 commit into
Conversation
valthon
changed the base branch from
master
to
fix/generate-opp-bundles-script-rename
July 31, 2026 23:28
The argless build documented in LOCAL_DOCKER_E2E_CLUSTER_GUIDE.md used the Dockerfile's GIT_BRANCH_* defaults, which still pointed at pre-integration feature branches (wire-sysio feature/opp-part2, wire-solana feature/opp-solana-outpost-integration, wire-ethereum feature/protobufs-for-opp) — two branch generations behind what the repo manifest tracks today. Point the defaults at the current mainlines instead (sysio=master, solana=next, ethereum=next; cdt/libraries-ts/tools-ts were already on master), so a no-args build produces an image of the current platform. Note: master's wire-sysio ships generate-opp-bundles.sh (renamed from .fish), so this depends on the wire-local-setup.bash rename support landing first — merge after that PR. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01K4FBvbwEeTj7ByeJzjehbQ
valthon
force-pushed
the
fix/e2e-build-default-refs
branch
from
August 3, 2026 13:21
0ca7305 to
2119e6e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
The
e2e-build.DockerfileGIT_BRANCH_*defaults still pointed at pre-integration feature branches — two branch generations behind what the repo manifest tracks today:feature/opp-part2masterfeature/opp-solana-outpost-integrationnextfeature/protobufs-for-oppnextmasterThe argless build documented in
LOCAL_DOCKER_E2E_CLUSTER_GUIDE.mduses these defaults, so until now a no-args build produced an image of long-dead branches. With this change it produces an image of the current platform mainlines.Please veto/adjust if a different default set is intended — the new values mirror the repo manifest (
m/mastertracking refs) as of 2026-07-24.Merge order
This PR is stacked on #3 (wire-sysio
mastershipsgenerate-opp-bundles.sh, renamed from.fishin8ce1b9bf90; #3 teacheswire-local-setup.bashthe new name). The stack enforces bottom-up merging — merging this PR merges #3 with it, and merging #3 alone auto-retargets this PR back tomaster.Verification
A full
wire-e2e-envbuild against this exact ref set (sysio=master, ethereum=next, solana=next-integ, plus #3's script change) completed green end-to-end locally on 2026-07-24.🤖 Generated with Claude Code
https://claude.ai/code/session_01K4FBvbwEeTj7ByeJzjehbQ