🌐 Updated Korean (ko) translations#29094
Conversation
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ✅ Looks good — no concerns flagged
Reviewed 189 translations across 3 files.
This is an excellent and thorough update to the Korean translations. The language is natural, consistent, and appropriately friendly throughout all three files. The use of 홍길동 as the placeholder name for "Jamie Larson" is a perfect choice — it's the quintessential Korean placeholder name, well-known and gender-neutral in usage. The email placeholder gildong@example.com is a clever and consistent companion to that choice. Placeholders, inline tags, and ending punctuation all look correct. The informal-but-polite register (using ~요 endings) is used consistently and suits Ghost's brand voice well. 감사합니다!
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThis pull request updates Korean locale strings in Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
ghost/i18n/locales/ko/ghost.json (1)
52-52: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winInconsistent particle form for dynamic
{email}placeholder.Line 52 uses a fixed "으로" ("{email}으로 전송되었어요.") while line 73 in the same file uses the parenthetical form "(으)로" ("{email}(으)로 전송되었어요.") for the same dynamic placeholder. Since the correct Korean particle depends on whether the substituted email string ends in a consonant or vowel sound, the fixed form can read as grammatically off for some dynamic values. Consider aligning with the "(으)로" pattern used elsewhere for consistency.
✏️ Suggested fix
- "Sent to {email}": "{email}으로 전송되었어요.", + "Sent to {email}": "{email}(으)로 전송되었어요.",🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@ghost/i18n/locales/ko/ghost.json` at line 52, The Korean translation for the Sent to {email} message uses a fixed particle form that is inconsistent with the other localized string for the same placeholder. Update the entry in ghost/i18n/locales/ko/ghost.json for the Sent to {email} translation to use the same dynamic Korean particle pattern as the existing later translation, so the grammar adapts correctly based on the {email} value; check the related localization entry for the matching {email}(으)로 phrasing and align this string accordingly.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@ghost/i18n/locales/ko/ghost.json`:
- Line 52: The Korean translation for the Sent to {email} message uses a fixed
particle form that is inconsistent with the other localized string for the same
placeholder. Update the entry in ghost/i18n/locales/ko/ghost.json for the Sent
to {email} translation to use the same dynamic Korean particle pattern as the
existing later translation, so the grammar adapts correctly based on the {email}
value; check the related localization entry for the matching {email}(으)로
phrasing and align this string accordingly.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 545db52c-a9a1-4cd5-bb45-7fa50cc5d8e5
📒 Files selected for processing (3)
ghost/i18n/locales/ko/comments.jsonghost/i18n/locales/ko/ghost.jsonghost/i18n/locales/ko/portal.json
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ✅ Looks good — no concerns flagged
Reviewed 190 translations across 3 files.
This is an excellent and thorough update to the Korean locale files. The translations are natural, consistent, and well-suited to Ghost's friendly, informal tone. The use of 홍길동 as the placeholder name for "Jamie Larson" is a great choice — it's the classic Korean placeholder name, analogous to "John Doe" in English. Placeholder variables, inline tags, and punctuation are all handled correctly throughout. 감사합니다!
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
ref TryGhost#23361 - Filled remaining untranslated strings and fixed a few existing ones - Used 홍길동 for the "Jamie Larson" placeholder
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ✅ Looks good — no concerns flagged
Reviewed 190 translations across 3 files.
This is a thorough and high-quality Korean translation. The strings are natural, consistent in tone (friendly informal 해요체 throughout), placeholders are all intact, inline tags are preserved, and the choice of 홍길동 as the placeholder name for "Jamie Larson" is excellent — it's the classic Korean everyman name. The example email placeholder gildong@example.com is a nice touch too. No issues were found. 감사합니다!
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
|
Bugbot is not enabled for this team, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
There was a problem hiding this comment.
🌐 Automated translation review
Verdict: ✅ Looks good — no concerns flagged
Reviewed 190 translations across 3 files.
This is a thorough and high-quality Korean translation update. The strings are accurate, natural-sounding, and consistent in tone throughout all three files. The use of 홍길동 as the placeholder name for "Jamie Larson" is an excellent choice — it's the quintessential Korean placeholder name, ungendered in usage, and widely recognised. The localised email placeholder (gildong@example.com) is a nice touch too. Formality is consistent across the files, and all placeholders and inline tags appear to be intact. 감사합니다!
Advisory review by i18n-review-bot. Non-blocking — a maintainer still owns the merge decision, and the bot cannot approve PRs on its own. Translator expertise wins where there is doubt.
|
| Command | Status | Duration | Result |
|---|---|---|---|
nx run @tryghost/admin-x-settings:test:acceptance |
✅ Succeeded | 10m 25s | View ↗ |
nx run ghost:test:ci:integration |
✅ Succeeded | 2m 45s | View ↗ |
nx run ghost:test:integration |
✅ Succeeded | 2m 51s | View ↗ |
nx run-many --target=build --projects=tag:publi... |
✅ Succeeded | 1s | View ↗ |
nx run ghost:test:legacy |
✅ Succeeded | 2m 54s | View ↗ |
nx run ghost:test:e2e |
✅ Succeeded | 2m 28s | View ↗ |
nx run-many -t test:unit -p @tryghost/admin-x-s... |
✅ Succeeded | 2m 47s | View ↗ |
nx run-many -t lint -p @tryghost/i18n,@tryghost... |
✅ Succeeded | 1m 14s | View ↗ |
Additional runs (5) |
✅ Succeeded | ... | View ↗ |
💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗
☁️ Nx Cloud last updated this comment at 2026-07-07 21:03:36 UTC
2 participants
ref #23361
Got some code for us? Awesome 🎊!
Please take a minute to explain the change you're making:
Please check your PR against these items:
We appreciate your contribution! 🙏