Fix Gemma remat static argument for dropout - #1021
Open
primorLee wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nn.rematstatic argument index for Gemma blocksWhy
Flax Linen's lifted checkpoint transform interprets
static_argnumsagainst the original module method signature, includingself, and then shifts the indices internally.Block.__call__therefore needs index6fordeterministic.With index
5,adarms_condis selected instead anddeterministicremains traced. Enabling Gemma dropout then reaches Flax's Python boolean branch with a traced value and raisesTracerBoolConversionErrorduring model initialization.The regression test uses the real
gemma.Moduleremat + scan + dropout path with a one-layer dummy config and a reduced vocabulary for speed.Fixes #987
Testing
pytest -q src/openpi/models/gemma_test.py(1 passed)pre-commit run --files src/openpi/models/gemma.py src/openpi/models/gemma_test.py