-
Notifications
You must be signed in to change notification settings - Fork 2
Resolver Specific Parameters (ID5 Mobile In-App) #40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Riabkov
wants to merge
6
commits into
Optable:master
Choose a base branch
from
postindustria-tech:feature/id5-targeting-params
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0759d22
- Enrich OptableSDK.tageting with hids
Riabkov af42be6
- Update id5 parsing, take from refs
Riabkov 42a5f11
fix: skip malformed eid entries when parsing the ID5 signature
justadreamer d061bc1
fix: resolve default UA via WebSettings.getDefaultUserAgent
justadreamer 9bf259a
tests: cover id5 signature storage and its removal by clearTargeting
justadreamer 6bcbf70
chore: fix nits
justadreamer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44 changes: 44 additions & 0 deletions
44
android_sdk/src/main/java/co/optable/sdk/core/AppInfoHolder.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,44 @@ | ||
| package co.optable.sdk.core | ||
|
|
||
| import android.content.Context | ||
| import android.util.Log | ||
| import co.optable.sdk.OptableConfig | ||
|
|
||
| /** | ||
| * Resolves and caches platform-specific application information used by resolvers such as | ||
| * ID5 Mobile In-App and Audigent Hadron: | ||
| * - [bundle]: the application's package name (the mobile app's unique identifier). | ||
| * - [appVersion]: the application's version name. | ||
| * | ||
| * Both values are resolved once, at construction, and fall back to `null` (never an empty | ||
| * string) when they cannot be determined. | ||
| */ | ||
| internal class AppInfoHolder( | ||
| config: OptableConfig, | ||
| ) { | ||
|
|
||
| val bundle: String? = resolveBundle(config.context) | ||
| val appVersion: String? = resolveAppVersion(config.context) | ||
|
|
||
| private fun resolveBundle(context: Context): String? { | ||
| return try { | ||
| context.packageName?.takeIf { it.isNotBlank() } | ||
| } catch (e: Exception) { | ||
| Log.w("OptableSDK", "Can't resolve app bundle: ${e.message}") | ||
| null | ||
| } | ||
| } | ||
|
|
||
| private fun resolveAppVersion(context: Context): String? { | ||
| return try { | ||
| context.packageManager | ||
| .getPackageInfo(context.packageName, 0) | ||
| .versionName | ||
| ?.takeIf { it.isNotBlank() } | ||
| } catch (e: Exception) { | ||
| Log.w("OptableSDK", "Can't resolve app version: ${e.message}") | ||
| null | ||
| } | ||
| } | ||
|
|
||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 changes: 6 additions & 4 deletions
10
android_sdk/src/main/java/co/optable/sdk/core/UserAgentHolder.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.