Skip to content

Resolver Specific Parameters (ID5 Mobile In-App)#40

Open
Riabkov wants to merge 6 commits into
Optable:masterfrom
postindustria-tech:feature/id5-targeting-params
Open

Resolver Specific Parameters (ID5 Mobile In-App)#40
Riabkov wants to merge 6 commits into
Optable:masterfrom
postindustria-tech:feature/id5-targeting-params

Conversation

@Riabkov

@Riabkov Riabkov commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Closes #39

  • New targeting(ids, hids, listener) overload. The old signature still works, forwards an empty list.
  • Four new query params on every targeting call: bundle, ver, ua, id5_signature. A new AppInfoHolder resolves package name and version once, degrading to null rather than empty strings.
  • ID5 signature round-trip: when a targeting response contains an ID5 signature, the SDK caches it in local storage and resends it on subsequent calls to improve resolve rate and accuracy

Riabkov and others added 6 commits July 3, 2026 14:17
@Riabkov
- Enrich OptableSDK.tageting with hids
0759d22 
- Add hids, bundle, ver, ua, id5_signature to targeting API
- Add AppInfoHolder.kt for bundle and appVersion
- Add id5_signature to LocalStorage.kt
@Riabkov
- Update id5 parsing, take from refs
af42be6 
- Update unit tests
@justadreamer
fix: skip malformed eid entries when parsing the ID5 signature
42a5f11 
A single malformed entry early in eids no longer aborts the scan and
silently drops a valid ID5 entry that follows it.
@justadreamer
fix: resolve default UA via WebSettings.getDefaultUserAgent
d061bc1 
WebView(context) requires the main thread; constructing the SDK off it
silently dropped both the ua param and the User-Agent header, which ID5
resolution depends on. WebSettings.getDefaultUserAgent works on any
thread and avoids constructing a WebView.
@justadreamer
tests: cover id5 signature storage and its removal by clearTargeting
9bf259a
@justadreamer
chore: fix nits
6bcbf70 
- stray space before comma in the targeting call
- README hint example used Apple-only identifiers (IDFA/IDFV) on Android
- README: note that any identifier type is forwarded as a hint as-is,
  consumption is decided server-side
- stale test comment referencing a nonexistent gate
mosherBT
mosherBT reviewed Jul 24, 2026
View reviewed changes
Comment thread README.md
Comment thread README.md

- `bundle` — the app's package name.
- `ver` — the app's version name.
- `ua` — the device user agent (the same value sent in the `User-Agent` header; overridable via `customUserAgent`).

@mosherBT mosherBT Jul 24, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do GDPR signals already come through the android SDK?

@Riabkov Riabkov Jul 27, 2026 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, RequestInterceptor appends gdpr, gdpr_consent, gpp, gpp_sid, and reg to outgoing requests

@mosherBT

mosherBT commented Jul 24, 2026

Copy link
Copy Markdown

I will merge this PR to add a template to this repo. Can you fill out some more info the description please. Nothing big just brief
#43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mosherBT mosherBT mosherBT approved these changes
@jrosendahl-opt jrosendahl-opt Awaiting requested review from jrosendahl-opt

Assignees

@Riabkov Riabkov

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Resolver Specific Parameters (ID5 Mobile In-App)

3 participants

@Riabkov @mosherBT @justadreamer