fix(riscv): canonicalize reserved WARL encodings in four CSRs - #312
Open
carlosqwqqwq wants to merge 4 commits into
Open
fix(riscv): canonicalize reserved WARL encodings in four CSRs#312carlosqwqqwq wants to merge 4 commits into
carlosqwqqwq wants to merge 4 commits into
Conversation
carlosqwqqwq
force-pushed
the
fix-riscv-warl-csr-canonicalize
branch
from
August 14, 2026 03:29
060a3c8 to
71c52eb
Compare
Contributor
Author
|
The Root cause: this PR's CI merge base is |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mstatus.MPP,mip,midelegandmedelegare WARL CSRs: writes to reserved fields must be canonicalized to the legal value set. RAX'scsr_writestored the raw value, so reserved encodings (MPP=0b10, mip[0], mideleg[0], medeleg[10]) became readable.This change masks the WARL fields in
csr_writefor these four CSRs: MPP to the implemented privilege set, mip/mideleg to the writable interrupt bits, and medeleg to the delegatable exception causes.Validation
cargo test --libtargeted tests pass; full suite shows no regressions.Closes #307