fix(riscv): take pending interrupt trap in wfi - #295
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for the report and patch. I independently checked WFI against the privileged architecture and implemented the valid part in #296: a locally enabled pending interrupt wakes WFI irrespective of the global enable. The rollup does not force a trap when global/delegation conditions make that interrupt non-actionable, because wake eligibility and trap eligibility are distinct. It includes your co-author credit and asks for your review. I’m closing this PR as superseded by #296. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make
wfitake the interrupt trap immediately when an enabled interrupt ispending, per priv 1.12 norm:wfi_mepc_val. Currently
Op::Wfialways returnsOk(RiscVExit::Wfi)(stall hint) even whenmip & mieis non-zero.Validation
defect is fixed.
returns
Wfi; pending enabled interrupt -> traps.(R-010..R-014 for the sret/wfi fixes, R-023 for the segment-ff decode fix,
R-017 obsolete, V-012 already adopted upstream).
cargo test --libpasses.Closes #290