fix(riscv): require aligned register groups for vssrl/vssra - #285
Closed
carlosqwqqwq wants to merge 2 commits into
Closed
fix(riscv): require aligned register groups for vssrl/vssra#285carlosqwqqwq wants to merge 2 commits into
carlosqwqqwq wants to merge 2 commits into
Conversation
Member
|
Thanks for the report and patch. I independently reproduced and validated the scaling-shift alignment gap, then reimplemented it through the shared RVV validator with expanded tests in #296. The rollup includes your co-author credit and asks for your review. I’m closing this PR as superseded by #296. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #280
Summary
The scaling shift instructions
vssrlandvssraname vector register groups invd,vs2and (for the.vvform)vs1, and the RISC-V V extension requires each group to be specified by its lowest-numbered register (riscv-v-spec, Section 3.4.2). The affectedVssrl | Vssrabranch executed the shift without any register-group alignment check, so reserved encodings such asvssrl.vv v1, v2, v2with e32/m2 (vd=v1 misaligned) were executed. QEMU raises SIGILL for these encodings viaopivv_check/opivx_check.The fix rejects any
.vvform with a misaligned vd, vs1 or vs2, and any.vx/.viform with a misaligned vd or vs2, computing EMUL from vtype.Validation
cargo test --lib: the targeted scaling-shift alignment tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.