fix(riscv): require aligned sources and non-overlapping dest for vmseq family - #283
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
fix(riscv): require aligned sources and non-overlapping dest for vmseq family#283carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
Member
|
Thanks for the report and patch. I independently validated the comparison operand constraints and reimplemented the accepted source-alignment and legal mask-destination overlap behavior with source snapshots in #296. The rollup includes your co-author credit and asks for your review. I’m closing this PR as superseded by #296. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #278
Summary
The comparison instructions
vmseq,vmsne,vmsltu,vmslt,vmsleu,vmsle,vmsgtuandvmsgtname vector register groups in the sources but write a single mask register. The RISC-V V extension requires each source group to be specified by its lowest-numbered register (riscv-v-spec, Section 3.4.2) and the destination must not overlap a source group (Section 5.2). The affectedVmseq | Vmsne | Vmsltu | Vmslt | Vmsleu | Vmsle | Vmsgtu | Vmsgtbranch executed the comparison without any check, so reserved encodings such asvmseq.vv v2, v3, v4with e32/m2 (vs2=v3 misaligned) were executed. QEMU raises SIGILL for these encodings viavext_check_mss/vext_check_ms.The fix rejects any comparison with a misaligned vs2 (and vs1 for the
.vvform) or with vd overlapping a source group, computing EMUL from vtype.Validation
cargo test --lib: the targeted comparison-family alignment tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.