fix(riscv): require aligned destination for vid.v - #282
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for the report and patch. I independently reproduced and validated the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #277
Summary
vid.vwrites one SEW-wide element index per element into a destination vector register group whose EMUL equals LMUL, and the RISC-V V extension requires every vector register group to be named by its lowest-numbered register (riscv-v-spec, Section 3.4.2). The affectedOp::Vidbranch executedvd[i] = iwithout any alignment check, so reserved encodings such asvid.v v1with e8/m2 were executed. QEMU raises SIGILL for these encodings viatrans_vid_v/require_align(a->rd, s->lmul).The fix rejects any
vid.vwhose destination register number is not aligned to the current LMUL (mapping thevlmulfield ofvtypeto an EMUL of 1/2/4/8).Validation
cargo test --lib: the targeted vid.v alignment tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.