fix(riscv): reject vmadc/vmsbc mask results overlapping sources - #274
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
fix(riscv): reject vmadc/vmsbc mask results overlapping sources#274carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
Member
|
Thanks for the report and patch. I independently reproduced and validated this issue, then reimplemented the accepted mask-result overlap behavior with source snapshots and expanded direct/SMIR tests in #296. That rollup includes your co-author credit and asks for your review. I’m closing this PR as superseded by #296. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #269
Summary
The carry/borrow-producing instructions
vmadc.vv/vmadc.vx/vmadc.vi/vmsbc.vv/vmsbc.vxwrite a single mask-result register (EEW=1) while reading SEW-width register groups fromvs2andvs1. A destination that falls inside a source register group is a reserved encoding unless it names the lowest-numbered register of that group. The affectedVmadc/Vmsbcexecution path performed no overlap check, so reserved encodings executed and wrote the mask result into a register that was simultaneously read as part of a source group. QEMU raises SIGILL for the same encodings.The fix adds the mask-result overlap rule to the vector legality checks: the destination may overlap a source group only when it names the lowest-numbered register of that group.
vs2is checked in every form;rs1is checked only in thevvform, because thevxform reads a scalar fromrs1and theviform reads a 5-bit immediate — neither may be treated as a vector register number.Validation
No new upstream test files are added; this is a source-only change.