fix(riscv): resume whole-register moves from vstart - #273
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
Conversation
carlosqwqqwq
force-pushed
the
fix-riscv-vmvr-vstart
branch
from
August 13, 2026 05:08
3d02861 to
1d3912f
Compare
Member
|
Thanks for the report and patch. I independently validated the whole-register move semantics and reimplemented them in #296, including |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #268
Summary
Every vector instruction, including whole-register moves, begins at the element number given in
vstartand leaves earlier destination bytes undisturbed (V specnorm:vstart_op). The affectedOp::Vmvrpath copied the whole register group from byte 0 regardless ofvstart, so a resumable trap sequence (or any nonzerovstart) corrupted the bytes beforevstart. QEMU keeps the earlier bytes undisturbed.The fix changes the
Op::Vmvrloop to start atvstart.min(total)instead of0.Validation
cargo test --lib: the targeted whole-register-move test passes, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.