fix(riscv): reject viota.m with vd == vs2 - #271
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
Conversation
Member
|
Thanks for the report and patch. The |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #266
Summary
The vector iota instruction (
viota.m) readsvs2element-by-element and writes the running count tovd; the specification reserves the encoding when the destination aliases the source register. The affectedOp::Viotapath had novd==vs2check, soviota.m v2, v2executed with the destination overwriting the source mid-scan. QEMU raises SIGILL for the same encoding.The fix adds the
vd==vs2rejection to theOp::Viotabranch.Validation
cargo test --lib: the targeted viota test passes, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.