fix(riscv): reject reserved CBO funct7 encodings - #262
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
Conversation
carlosqwqqwq
force-pushed
the
fix-riscv-cbo-funct7-full
branch
from
August 13, 2026 05:07
d0f0f79 to
5a60cb8
Compare
Member
|
Thanks for the report and patch. I independently reproduced and validated this issue, then reimplemented the accepted behavior with shared direct/SMIR validation and expanded tests in #296. That rollup includes your co-author credit and asks for your review. I’m closing this PR as superseded by #296 so the fixes can be reviewed and merged as one coherent change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #257
Summary
The Zicbom / Zicboz instructions are encoded with a full 7-bit
funct7field of0b0000000. The affected decoder only checked the top five bits offunct7((w >> 27) & 0x1f == 0), so any encoding whosefunct7[1:0]is nonzero — a reserved encoding that must raise an illegal-instruction exception — was still decoded ascbo.inval/cbo.clean/cbo.flush/cbo.zero. QEMU raises SIGILL for the same encoding (0x0605200f) because its decoder matches the full 7-bitfunct7pattern.The fix checks the full 7-bit
funct7in the CBO decode path.Validation
cargo test --lib: the targeted CBO decode tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.