fix(riscv): gate RV32 compressed single-precision memory ops on F - #261
Closed
carlosqwqqwq wants to merge 1 commit into
Closed
fix(riscv): gate RV32 compressed single-precision memory ops on F#261carlosqwqqwq wants to merge 1 commit into
carlosqwqqwq wants to merge 1 commit into
Conversation
Member
|
Thanks for the report and patch. I independently reproduced and validated this issue, then reimplemented the accepted behavior with shared direct/SMIR validation and expanded tests in #296. That rollup includes your co-author credit and asks for your review. I’m closing this PR as superseded by #296 so the fixes can be reviewed and merged as one coherent change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #256
Summary
The RV32 compressed single-precision load/store encodings
c.flw/c.fsw/c.flwsp/c.fswspbelong to the Zcf extension, which is only defined when the F extension is present. Without F, these code points are reserved and must decode as illegal. The affected RV32 compressed decoder emittedFlw/Fswfor these encodings unconditionally, so a guest configured without F executed them instead of taking an illegal-instruction trap. QEMU raises SIGILL for the same encodings.The fix adds the F-extension gate to the four RV32 decode paths in the compressed decoder, mirroring the existing D-extension gates for the double-precision compressed loads/stores.
Validation
cargo test --lib: the targeted compressed-load/store tests pass, and the full library test suite passes with no regressions.No new upstream test files are added; this is a source-only change.