Skip to content

Charts: inject wpds fallbacks during build - #50614

Open
simison wants to merge 4 commits into
trunkfrom
update/charts-wpds-fallbacks
Open

Charts: inject wpds fallbacks during build#50614
simison wants to merge 4 commits into
trunkfrom
update/charts-wpds-fallbacks

Conversation

@simison

@simison simison commented Jul 17, 2026

Copy link
Copy Markdown
Member

WIP

Depends either on WordPress/gutenberg#80401 which adds LightningCSS plugin for WPDS fallbacks in wp-theme, or switching to PostCSS.

Similar to one done for social-previews in #50646

Proposed changes

  • Lints against adding wpds token fallbacks in CSS
  • Removes manually added WPDS fallbacks from CSS and JS
  • Configures LightningCSS (WIP) and Vite plugins from @wordpress/theme to add fallbacks during build time.

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

*WIP

@github-actions

Copy link
Copy Markdown
Contributor
Are you an Automattician? The PR will need to be tested on WordPress.com. This comment will be updated with testing instructions as soon the build is complete.

@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · PHP report · JS report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant