Skip to content

Stylelint: enable no-token-fallback-values (almost) everywhere - #50645

Merged
simison merged 1 commit into
trunkfrom
update/stylelint-wpds-fallbacks-everywhere
Jul 17, 2026
Merged

Stylelint: enable no-token-fallback-values (almost) everywhere#50645
simison merged 1 commit into
trunkfrom
update/stylelint-wpds-fallbacks-everywhere

Conversation

@simison

@simison simison commented Jul 17, 2026

Copy link
Copy Markdown
Member

Follow-up to linter config started at:

...and numerous PRs meanwhile to add fallback token handling and linting to big chunk of the repo.

Among files with --wpds-* the linter + build time fallbacks now cover:

Covered Total %
Files 147 173 85.0%
Packages 16 21 76.2%

Not on the rule: charts, components, base-styles, social-previews, plugins/jetpack

Those others are pretty complicated:

Proposed changes

  • Enable no-token-fallback-values by default, except on folders still not going through build pipeline that adds the tokens at build-time.

Related product discussion/links

Does this pull request change what data or activity we track or use?

Testing instructions

  • Lint is passing.

@simison
simison requested a review from a team as a code owner July 17, 2026 21:13
@simison simison added [Status] Ready to Merge Go ahead, you can push that green button! Build labels Jul 17, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@simison
simison merged commit 74b3724 into trunk Jul 17, 2026
76 of 77 checks passed
@simison
simison deleted the update/stylelint-wpds-fallbacks-everywhere branch July 17, 2026 21:27
@github-actions github-actions Bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Jul 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant