Add e_qcstatem_psd2_roles_valid: role name/OID validation for PSD2 QCStatements - #1077
Open
christopher-henderson wants to merge 3 commits into
Open
Add e_qcstatem_psd2_roles_valid: role name/OID validation for PSD2 QCStatements#1077christopher-henderson wants to merge 3 commits into
christopher-henderson wants to merge 3 commits into
Conversation
Replaces the struct-slice plus nested-loop-with-break scan with a direct map lookup keyed by the OID's dotted string form, removing a level of nesting and the O(roles*9) scan for what is really a single-key lookup.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
e_qcstatem_psd2_roles_validthat checks each recognized role OID in a PSD2 QCStatement's RolesOfPSP has the matching registered role name (ETSI TS 119 495, REG-5.2.2-5).