Skip to content

TVec template fixes - #3170

Open
LagoLunatic wants to merge 2 commits into
zeldaret:mainfrom
LagoLunatic:tvec
Open

TVec template fixes#3170
LagoLunatic wants to merge 2 commits into
zeldaret:mainfrom
LagoLunatic:tvec

Conversation

@LagoLunatic

Copy link
Copy Markdown
Contributor

Adds template <class U> to some template functions that were missing it based on the debug maps. Also fixes the casts inside set to cast to the type being stored instead of the template function type.

@decomp-dev

decomp-dev Bot commented Jul 31, 2026

Copy link
Copy Markdown

Report for RZDP01 (c8fa8c9 - 510f01d)

📈 Matched code: 53.72% (+0.00%, +16 bytes)

✅ 1 new match
Unit Item Bytes Before After
framework/d/d_particle void* JGeometry::TVec3<short>::TVec3<short>(short, short, short) +16 0.00% 100.00%

Report for RZDE01_00 (c8fa8c9 - 510f01d)

📈 Matched code: 47.06% (+0.00%, +16 bytes)

✅ 1 new match
Unit Item Bytes Before After
framework/d/d_particle void* JGeometry::TVec3<short>::TVec3<short>(short, short, short) +16 0.00% 100.00%

Report for RZDJ01 (c8fa8c9 - 510f01d)

📈 Matched code: 53.85% (+0.00%, +16 bytes)

✅ 1 new match
Unit Item Bytes Before After
framework/d/d_particle void* JGeometry::TVec3<short>::TVec3<short>(short, short, short) +16 0.00% 100.00%

Report for GZ2P01 (c8fa8c9 - 510f01d)

No changes

Report for GZ2E01 (c8fa8c9 - 510f01d)

No changes

Report for Shield (c8fa8c9 - 510f01d)

No changes

Report for ShieldD (c8fa8c9 - 510f01d)

📈 Matched code: 54.48% (+0.01%, +2172 bytes)

✅ 7 new matches
Unit Item Bytes Before After
framework/d/d_particle void JGeometry::TVec3<float>::cubic<float>(const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, const JGeometry::TVec3<float>&, float) +352 0.00% 100.00%
framework/d/d_particle void* JGeometry::TVec3<short>::TVec3<short>(short, short, short) +76 0.00% 100.00%
framework/d/d_particle void JGeometry::TVec3<short>::set<short>(short, short, short) +28 0.00% 100.00%
framework/JSystem/JStudio/JStudio/jstudio-math void JGeometry::TVec3<double>::set<double>(double, double, double) +16 0.00% 100.00%
framework/d/actor/d_a_alink JPABaseEmitter::setLocalRotation(const JGeometry::TVec3<short>&) +1 99.91% 100.00%
framework/JSystem/JParticle/JPAEmitter JPADynamicsBlock::getEmitterRot(JGeometry::TVec3<short>*) const +1 99.77% 100.00%
framework/JSystem/JStudio/JStudio_JParticle/object-particle JStudio_JParticle::TAdaptor_particle::TJPACallback_emitter_::execute(JPABaseEmitter*) +1 99.99% 100.00%
📈 1 improvement in an unmatched item
Unit Item Bytes Before After
d_a_kytag03/d/actor/d_a_kytag03 daKytag03_Execute(kytag03_class*) +16 87.64% 88.76%

Report for GZ2J01 (c8fa8c9 - 510f01d)

No changes

Report for RZDE01_02 (c8fa8c9 - 510f01d)

📈 Matched code: 54.68% (+0.00%, +16 bytes)

✅ 1 new match
Unit Item Bytes Before After
framework/d/d_particle void* JGeometry::TVec3<short>::TVec3<short>(short, short, short) +16 0.00% 100.00%

Report for DZDE01 (c8fa8c9 - 510f01d)

📈 Matched code: 52.22% (+0.00%, +16 bytes)

✅ 1 new match
Unit Item Bytes Before After
framework/d/d_particle void* JGeometry::TVec3<short>::TVec3<short>(short, short, short) +16 0.00% 100.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant