Skip to content

fix(edit_block): run fuzzy search in a worker thread to keep event lo… #500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wonderwhy-er merged 5 commits into from
Jun 17, 2026
Merged

fix(edit_block): run fuzzy search in a worker thread to keep event lo… #500

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
37305bf
fix(edit_block): run fuzzy search in a worker thread to keep event lo…
edgarsskore Jun 9, 2026
4a015d1
fix: terminate fuzzy search worker on success
edgarsskore Jun 10, 2026
88902d4
refactor: extract fuzzy search into a dependency-free core module
edgarsskore Jun 10, 2026
9f5d3e0
test: handle rejection on the detached editPromise.finally chain
edgarsskore Jun 10, 2026
4110710
fix: seed iterativeReduction with the measured distance of its slice
edgarsskore Jun 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/tools/edit.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
import { getDefaultEditorMetadata, readFile, writeFile, readFileInternal, validatePath } from './filesystem.js';
import fs from 'fs/promises';
import { ServerResult } from '../types.js';
import { recursiveFuzzyIndexOf, getSimilarityRatio } from './fuzzySearch.js';
import { runFuzzySearchInWorker, getSimilarityRatio } from './fuzzySearch.js';
import { capture } from '../utils/capture.js';
import { createErrorResponse } from '../error-handlers.js';
import { EditBlockArgsSchema } from "./schemas.js";
Expand Down Expand Up @@ -251,9 +251,10 @@ RECOMMENDATION: For large search/replace operations, consider breaking them into
if (count === 0) {
// Track fuzzy search time
const startTime = performance.now();

// Perform fuzzy search
const fuzzyResult = recursiveFuzzyIndexOf(content, block.search);

// Perform fuzzy search in a worker thread so the main event loop stays
// responsive to pings and parallel tool calls during the scan
const fuzzyResult = await runFuzzySearchInWorker(content, block.search);
const similarity = getSimilarityRatio(block.search, fuzzyResult.value);

// Calculate execution time in milliseconds
Expand Down
208 changes: 78 additions & 130 deletions src/tools/fuzzySearch.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,140 +1,88 @@
import { distance } from 'fastest-levenshtein';
import { capture } from '../utils/capture.js';
import { Worker } from 'worker_threads';
import type { FuzzyMatch, FuzzySearchMetrics } from './fuzzySearchCore.js';

// Re-export so existing callers keep importing from this module.
export { recursiveFuzzyIndexOf, getSimilarityRatio } from './fuzzySearchCore.js';

/** Abort fuzzy search in the worker after this many ms to avoid unbounded CPU burn. */
export const FUZZY_SEARCH_TIMEOUT_MS = 30000;

/**
* Recursively finds the closest match to a query string within text using fuzzy matching
* @param text The text to search within
* @param query The query string to find
* @param start Start index in the text (default: 0)
* @param end End index in the text (default: text.length)
* @param parentDistance Best distance found so far (default: Infinity)
* @returns Object with start and end indices, matched value, and Levenshtein distance
* Inline worker entry: imports the dependency-free core module (passed as
* moduleUrl) and runs the search off the main thread. The core module is
* deliberately a leaf — importing this module (or anything app-level) from the
* worker would boot the whole server per search. Kept as an eval'd snippet so
* the worker needs no separate file to ship alongside the compiled output.
*/
export function recursiveFuzzyIndexOf(text: string, query: string, start: number = 0, end: number | null = null, parentDistance: number = Infinity, depth: number = 0): {
start: number;
end: number;
value: string;
distance: number;
} {
// For debugging and performance tracking purposes
if (depth === 0) {
const startTime = performance.now();
const result = recursiveFuzzyIndexOf(text, query, start, end, parentDistance, depth + 1);
const executionTime = performance.now() - startTime;

// Capture detailed metrics for the recursive search for in-depth analysis
capture('fuzzy_search_recursive_metrics', {
execution_time_ms: executionTime,
text_length: text.length,
query_length: query.length,
result_distance: result.distance
});

return result;
}

if (end === null) end = text.length;

// For small text segments, use iterative approach
if (end - start <= 2 * query.length) {
return iterativeReduction(text, query, start, end, parentDistance);
}

let midPoint = start + Math.floor((end - start) / 2);
let leftEnd = Math.min(end, midPoint + query.length); // Include query length to cover overlaps
let rightStart = Math.max(start, midPoint - query.length); // Include query length to cover overlaps

// Calculate distance for current segments
let leftDistance = distance(text.substring(start, leftEnd), query);
let rightDistance = distance(text.substring(rightStart, end), query);
let bestDistance = Math.min(leftDistance, parentDistance, rightDistance);

// If parent distance is already the best, use iterative approach
if (parentDistance === bestDistance) {
return iterativeReduction(text, query, start, end, parentDistance);
}

// Recursively search the better half
if (leftDistance < rightDistance) {
return recursiveFuzzyIndexOf(text, query, start, leftEnd, bestDistance, depth + 1);
} else {
return recursiveFuzzyIndexOf(text, query, rightStart, end, bestDistance, depth + 1);
}
}
const WORKER_CODE = `
const { workerData, parentPort } = require('worker_threads');
import(workerData.moduleUrl)
.then((m) => {
parentPort.postMessage({ ok: true, ...m.runFuzzySearch(workerData.text, workerData.query) });
})
.catch((err) => {
parentPort.postMessage({ ok: false, error: String(err && err.stack || err) });
});
`;

const CORE_MODULE_URL = new URL('./fuzzySearchCore.js', import.meta.url).href;

/**
* Iteratively refines the best match by reducing the search area
* @param text The text to search within
* @param query The query string to find
* @param start Start index in the text
* @param end End index in the text
* @param parentDistance Best distance found so far
* @returns Object with start and end indices, matched value, and Levenshtein distance
* Runs the fuzzy search in a Worker thread so the main MCP event loop stays
* responsive to pings and other tool calls during heavy scans. Rejects if the
* scan exceeds timeoutMs, terminating the worker so it doesn't linger in the
* background. Search metrics come back with the result and are captured here,
* on the main thread, where the client identity is initialized.
*/
function iterativeReduction(text: string, query: string, start: number, end: number, parentDistance: number): {
start: number;
end: number;
value: string;
distance: number;
} {
const startTime = performance.now();
let iterations = 0;

let bestDistance = parentDistance;
let bestStart = start;
let bestEnd = end;

// Improve start position
let nextDistance = distance(text.substring(bestStart + 1, bestEnd), query);

while (nextDistance < bestDistance) {
bestDistance = nextDistance;
bestStart++;
const smallerString = text.substring(bestStart + 1, bestEnd);
nextDistance = distance(smallerString, query);
iterations++;
}

// Improve end position
nextDistance = distance(text.substring(bestStart, bestEnd - 1), query);

while (nextDistance < bestDistance) {
bestDistance = nextDistance;
bestEnd--;
const smallerString = text.substring(bestStart, bestEnd - 1);
nextDistance = distance(smallerString, query);
iterations++;
}

const executionTime = performance.now() - startTime;

// Capture metrics for the iterative refinement phase
capture('fuzzy_search_iterative_metrics', {
execution_time_ms: executionTime,
iterations: iterations,
segment_length: end - start,
query_length: query.length,
final_distance: bestDistance
export function runFuzzySearchInWorker(
text: string,
query: string,
timeoutMs: number = FUZZY_SEARCH_TIMEOUT_MS
): Promise<FuzzyMatch> {
return new Promise((resolve, reject) => {
const worker = new Worker(WORKER_CODE, { eval: true, workerData: { moduleUrl: CORE_MODULE_URL, text, query } });
// Never let a scan keep the server process alive during shutdown.
worker.unref();

const timer = setTimeout(() => {
worker.terminate();
reject(new Error(`Fuzzy search timed out after ${timeoutMs}ms`));
}, timeoutMs);
timer.unref();

worker.on('message', (msg: { ok: true; result: FuzzyMatch; metrics: FuzzySearchMetrics } | { ok: false; error: string }) => {
clearTimeout(timer);
if (msg.ok) {
captureFuzzySearchMetrics(msg.metrics);
resolve(msg.result);
} else {
reject(new Error(`Fuzzy search worker failed: ${msg.error}`));
}
// Don't let the worker wind down on its own; the answer is already
// here, and a lingering worker holds its copy of the file text.
// The promise is settled, so the exit-code rejection below is a no-op.
worker.terminate();
});

worker.on('error', (err) => {
clearTimeout(timer);
reject(err);
});

worker.on('exit', (code) => {
clearTimeout(timer);
if (code !== 0) {
reject(new Error(`Fuzzy search worker exited with code ${code}`));
}
});
});

return {
start: bestStart,
end: bestEnd,
value: text.substring(bestStart, bestEnd),
distance: bestDistance
};
}

/**
* Calculates the similarity ratio between two strings
* @param a First string
* @param b Second string
* @returns Similarity ratio (0-1)
*/
export function getSimilarityRatio(a: string, b: string): number {
const maxLength = Math.max(a.length, b.length);
if (maxLength === 0) return 1; // Both strings are empty

const levenshteinDistance = distance(a, b);
return 1 - (levenshteinDistance / maxLength);
}
/** Same telemetry events the search used to emit inline, now sent from the main thread. */
function captureFuzzySearchMetrics(metrics: FuzzySearchMetrics): void {
capture('fuzzy_search_recursive_metrics', metrics.recursive);
if (metrics.iterative) {
capture('fuzzy_search_iterative_metrics', metrics.iterative);
}
}
Loading
Loading