Feature/welcome page ab test #298
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,109 @@ | ||
| import { configManager } from '../config-manager.js'; | ||
| import { featureFlagManager } from './feature-flags.js'; | ||
|
|
||
| /** | ||
| * A/B Test controlled feature flags | ||
| * | ||
| * Experiments are defined in remote feature flags JSON: | ||
| * { | ||
| * "flags": { | ||
| * "experiments": { | ||
| * "OnboardingPreTool": { | ||
| * "variants": ["noOnboardingPage", "showOnboardingPage"] | ||
| * } | ||
| * } | ||
| * } | ||
| * } | ||
| * | ||
| * Usage: | ||
| * if (await hasFeature('showOnboardingPage')) { ... } | ||
| */ | ||
|
|
||
| interface Experiment { | ||
| variants: string[]; | ||
| } | ||
|
|
||
| // Cache for variant assignments (loaded once per session) | ||
| const variantCache: Record<string, string> = {}; | ||
|
|
||
| /** | ||
| * Get experiments config from feature flags | ||
| */ | ||
| function getExperiments(): Record<string, Experiment> { | ||
| return featureFlagManager.get('experiments', {}); | ||
| } | ||
|
|
||
| /** | ||
| * Get user's variant for an experiment (cached, deterministic) | ||
| */ | ||
| async function getVariant(experimentName: string): Promise<string | null> { | ||
| const experiments = getExperiments(); | ||
| const experiment = experiments[experimentName]; | ||
| if (!experiment?.variants?.length) return null; | ||
|
|
||
| // Check cache | ||
| if (variantCache[experimentName]) { | ||
| return variantCache[experimentName]; | ||
| } | ||
|
|
||
| // Check persisted assignment | ||
| const configKey = `abTest_${experimentName}`; | ||
| const existing = await configManager.getValue(configKey); | ||
|
|
||
| if (existing && experiment.variants.includes(existing)) { | ||
| variantCache[experimentName] = existing; | ||
| return existing; | ||
| } | ||
|
|
||
| // New assignment based on clientId | ||
| const clientId = await configManager.getValue('clientId') || ''; | ||
| const hash = hashCode(clientId + experimentName); | ||
| const variantIndex = hash % experiment.variants.length; | ||
| const variant = experiment.variants[variantIndex]; | ||
|
|
||
| await configManager.setValue(configKey, variant); | ||
| variantCache[experimentName] = variant; | ||
| return variant; | ||
| } | ||
|
|
||
| /** | ||
| * Check if a feature (variant name) is enabled for current user | ||
| */ | ||
| export async function hasFeature(featureName: string): Promise<boolean> { | ||
| const experiments = getExperiments(); | ||
| if (!experiments || typeof experiments !== 'object') return false; | ||
|
|
||
| for (const [expName, experiment] of Object.entries(experiments)) { | ||
| if (experiment?.variants?.includes(featureName)) { | ||
| const variant = await getVariant(expName); | ||
| return variant === featureName; | ||
| } | ||
| } | ||
| return false; | ||
| } | ||
|
|
||
| /** | ||
| * Get all A/B test assignments for analytics (reads from config) | ||
| */ | ||
| export async function getABTestAssignments(): Promise<Record<string, string>> { | ||
| const experiments = getExperiments(); | ||
| const assignments: Record<string, string> = {}; | ||
|
|
||
| for (const expName of Object.keys(experiments)) { | ||
| const configKey = `abTest_${expName}`; | ||
| const variant = await configManager.getValue(configKey); | ||
| if (variant) { | ||
| assignments[`ab_${expName}`] = variant; | ||
| } | ||
| } | ||
| return assignments; | ||
| } | ||
|
|
||
| function hashCode(str: string): number { | ||
| let hash = 0; | ||
| for (let i = 0; i < str.length; i++) { | ||
| hash = ((hash << 5) - hash) + str.charCodeAt(i); | ||
| hash |= 0; | ||
| } | ||
| return Math.abs(hash); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import { execFile, spawn } from 'child_process'; | ||
| import os from 'os'; | ||
| import { logToStderr } from './logger.js'; | ||
|
|
||
| /** | ||
| * Open a URL in the default browser (cross-platform) | ||
| * Uses execFile/spawn with args array to avoid shell injection | ||
| */ | ||
| export async function openBrowser(url: string): Promise<void> { | ||
| const platform = os.platform(); | ||
|
|
||
| return new Promise((resolve, reject) => { | ||
| const callback = (error: Error | null) => { | ||
| if (error) { | ||
| logToStderr('error', `Failed to open browser: ${error.message}`); | ||
| reject(error); | ||
| } else { | ||
| logToStderr('info', `Opened browser to: ${url}`); | ||
| resolve(); | ||
| } | ||
| }; | ||
|
|
||
| switch (platform) { | ||
| case 'darwin': | ||
| execFile('open', [url], callback); | ||
| break; | ||
| case 'win32': | ||
| // Windows 'start' is a shell builtin, use spawn with shell but pass URL as separate arg | ||
| spawn('cmd', ['/c', 'start', '', url], { shell: false }).on('close', (code) => { | ||
| code === 0 ? resolve() : reject(new Error(`Exit code ${code}`)); | ||
| }); | ||
|
Comment on lines
+28
to
+31
Contributor
There was a problem hiding this comment. Windows code path bypasses callback and misses success logging. The Windows implementation uses 🔎 Proposed fix to unify error handling case 'win32':
- // Windows 'start' is a shell builtin, use spawn with shell but pass URL as separate arg
- spawn('cmd', ['/c', 'start', '', url], { shell: false }).on('close', (code) => {
- code === 0 ? resolve() : reject(new Error(`Exit code ${code}`));
- });
+ // Windows 'start' is a shell builtin, requires cmd.exe
+ spawn('cmd', ['/c', 'start', '', url], { shell: false }).on('close', (code) => {
+ callback(code === 0 ? null : new Error(`Exit code ${code}`));
+ });
break;🤖 Prompt for AI Agents |
||
| break; | ||
| default: | ||
| execFile('xdg-open', [url], callback); | ||
| break; | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| /** | ||
| * Open the Desktop Commander welcome page | ||
| */ | ||
| export async function openWelcomePage(): Promise<void> { | ||
| const url = 'https://desktopcommander.app/welcome/'; | ||
| await openBrowser(url); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| import { configManager } from '../config-manager.js'; | ||
| import { hasFeature } from './ab-test.js'; | ||
| import { openWelcomePage } from './open-browser.js'; | ||
| import { logToStderr } from './logger.js'; | ||
|
|
||
| /** | ||
| * Handle welcome page display for new users (A/B test controlled) | ||
| * | ||
| * Only shows to: | ||
| * 1. New users (first run - config was just created) | ||
| * 2. Users in the 'showOnboardingPage' A/B variant | ||
| * 3. Haven't seen it yet | ||
| */ | ||
| export async function handleWelcomePageOnboarding(): Promise<void> { | ||
| // Only for brand new users (config just created) | ||
| if (!configManager.isFirstRun()) { | ||
| return; | ||
| } | ||
|
|
||
| // Check A/B test assignment | ||
| const shouldShow = await hasFeature('showOnboardingPage'); | ||
| if (!shouldShow) { | ||
| logToStderr('debug', 'Welcome page skipped (A/B: noOnboardingPage)'); | ||
| return; | ||
| } | ||
|
|
||
| // Double-check not already shown (safety) | ||
| const alreadyShown = await configManager.getValue('sawOnboardingPage'); | ||
| if (alreadyShown) { | ||
| return; | ||
| } | ||
|
|
||
| try { | ||
| await openWelcomePage(); | ||
| await configManager.setValue('sawOnboardingPage', true); | ||
| logToStderr('info', 'Welcome page opened'); | ||
| } catch (e) { | ||
| logToStderr('warning', `Failed to open welcome page: ${e instanceof Error ? e.message : e}`); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
🏁 Script executed:
Repository: wonderwhy-er/DesktopCommanderMCP
Length of output: 100
🏁 Script executed:
Repository: wonderwhy-er/DesktopCommanderMCP
Length of output: 8079
🏁 Script executed:
Repository: wonderwhy-er/DesktopCommanderMCP
Length of output: 354
Fix privacy policy URL before release.
The manifest version bump to 0.3 and privacy_policies addition align with the new features. However, the privacy policy URL
https://legal.desktopcommander.app/privacy_desktop_commander_mcpreturns a 404 error and is not accessible. Ensure the correct URL is provided or the endpoint is deployed before shipping this release.🤖 Prompt for AI Agents