Better mount detection#289
Conversation
|
CodeAnt AI is reviewing your PR. Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
WalkthroughThe change enhances filesystem mount detection in system utilities by introducing filesystem-type classification. It adds categorization for system mounts and host-mounted resources, improves skip logic for non-user directories, and refines user-mount detection to consider filesystem types, host markers, and path patterns. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes
Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
codeant-ai
Bot
added
the
size:M
Nitpicks 🔍
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/utils/system-info.ts (1)
200-209: Consider hoisting filesystem-type sets to module scope for reuse and clarityDefining
systemFsTypesandhostMountFsTypesinside the loop body means newSetinstances are allocated on everydiscoverContainerMountscall. Functionally fine, but these are static classifications.Consider lifting them to top-level
constsets (or at least outside the/proc/mountsparsing block). That reduces allocations and centralizes the FS-type lists for future extension.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/utils/system-info.ts(1 hunks)
🔇 Additional comments (1)
src/utils/system-info.ts (1)
218-233: Verify whether skipping all/run*and other system paths matches your intended coverageThe
isSystemMountPointfilter excludes mounts under/dev*,/sys*,/proc*,/run*,/sbin, plus specific/etc/*files. This is a reasonable default for hiding low-level/system mounts, but it may also exclude any future host volumes that end up mounted directly under/run/....If in your Docker/Podman setups host-facing mounts can ever live under
/run(e.g.,/run/user/...or similar helper mounts you might want to expose), you may want a more targeted rule (e.g., only skip specific well-known system subpaths) instead of all/run*.
| // Detect user mounts by: | ||
| // 1. Known host-mount filesystem types (fakeowner, 9p, virtiofs) | ||
| // 2. Device from /run/host_mark/ (docker-mcp-gateway pattern) | ||
| // 3. Non-system filesystem type with user-like mount point | ||
| const isHostMountFs = hostMountFsTypes.has(fsType); | ||
| const isHostMarkDevice = device.startsWith('/run/host_mark/'); | ||
| const isNonSystemFs = !systemFsTypes.has(fsType); | ||
| const isUserLikePath = mountPoint.startsWith('/mnt/') || | ||
| mountPoint.startsWith('/workspace') || | ||
| mountPoint.startsWith('/data/') || | ||
| (mountPoint.startsWith('/home/') && !mountPoint.startsWith('/home/root'))) { | ||
|
|
||
| mountPoint.startsWith('/home/') || | ||
| mountPoint.startsWith('/Users/') || | ||
| mountPoint.startsWith('/app/') || | ||
| mountPoint.startsWith('/project/') || | ||
| mountPoint.startsWith('/src/') || | ||
| mountPoint.startsWith('/code/'); | ||
|
|
||
| if (isHostMountFs || isHostMarkDevice || (isNonSystemFs && isUserLikePath)) { | ||
| const isReadOnly = options.includes('ro'); |
There was a problem hiding this comment.
Tighten read-only detection and consider normalizing user-like path heuristics
The combined condition
if (isHostMountFs || isHostMarkDevice || (isNonSystemFs && isUserLikePath)) {is a solid improvement and should catch many realistic host mounts.
One minor correctness issue:
const isReadOnly = options.includes('ro');can misclassify mounts such as rw,errors=remount-ro as read-only because ro appears as a substring. It’s safer to parse mount options by token:
- const isReadOnly = options.includes('ro');
+ const mountOptions = options.split(',');
+ const isReadOnly = mountOptions.includes('ro');This avoids false positives while preserving behavior for true ro mounts.
As an optional polish, you might also consider whether isUserLikePath should distinguish /workspace from /workspace-* (currently startsWith('/workspace') matches both) and whether any additional project-specific prefixes should be centralized/configurable.
🤖 Prompt for AI Agents
In src/utils/system-info.ts around lines 234 to 252, the read-only detection
uses options.includes('ro') which can falsely match substrings like
"errors=remount-ro"; instead split or tokenize the mount options by comma (and
trim each token) and check for an exact 'ro' token (e.g.,
options.split(',').map(t=>t.trim()).includes('ro')). Update the isReadOnly
assignment to use this tokenized check. Optionally, when updating nearby code,
consider tightening the isUserLikePath heuristics (e.g., match '/workspace'
exactly or use a configurable prefix list) but the immediate fix is to replace
the substring check with a comma-token exact-match check for 'ro'.
|
CodeAnt AI finished reviewing your PR. |
1 participant
CodeAnt-AI Description
Improve container host mount detection in Linux containers
What Changed
Impact
✅ Clearer workspace mount detection✅ Fewer missed host-mounted directories✅ Fewer false positives from system filesystems💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Summary by CodeRabbit
Release Notes
✏️ Tip: You can customize this high-level summary in your review settings.