Skip to content

Feature/trim native tls and features - #187

Draft
mlemesle wants to merge 2 commits into
wolf4ood:masterfrom
mlemesle:feature/trim-native-tls-and-features
Draft

Feature/trim native tls and features#187
mlemesle wants to merge 2 commits into
wolf4ood:masterfrom
mlemesle:feature/trim-native-tls-and-features

Conversation

@mlemesle

@mlemesle mlemesle commented Apr 7, 2023

Copy link
Copy Markdown
Contributor

Supersedes #184

Closes #176 and #180

Hey there, I started again and successfully trimed native-tls from the dependencies and moved tokio-native-tls to rustls-webpki. All tests pass for async-std and tokio-runtime !

There is still some work to do:

  • Adapt Connectors configuration to rustls
  • Trim other dependencies
  • Rework the features => move async_gremlin to __async_gremlin, to show developers not to use it

I also added a compilation failure if someone tries to use async-std-runtime and tokio-runtime at the same time.

What do you think of this ?

@wolf4ood

wolf4ood commented Apr 7, 2023

Copy link
Copy Markdown
Owner

@mlemesle

looks great, just one thing, why the tungstenite dep is via github? is it missing something there yet not released?

@mlemesle

mlemesle commented Apr 7, 2023

Copy link
Copy Markdown
Contributor Author

I forgot to mention. There was a lot of dep version issues.
I had to fork 3 dependencies in order to fix this...
PR are submitted, I'm waiting for a release to add it to Cargo.toml!

What about my previous points?
Like moving async_gremlin to __async_gremlin?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Native TLS as optional

2 participants