Feature/trim native tls and features - #187
Draft
mlemesle wants to merge 2 commits into
Draft
Conversation
Owner
|
looks great, just one thing, why the tungstenite dep is via github? is it missing something there yet not released? |
Contributor
Author
|
I forgot to mention. There was a lot of dep version issues. What about my previous points? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #184
Closes #176 and #180
Hey there, I started again and successfully trimed native-tls from the dependencies and moved tokio-native-tls to rustls-webpki. All tests pass for async-std and tokio-runtime !
There is still some work to do:
I also added a compilation failure if someone tries to use
async-std-runtimeandtokio-runtimeat the same time.What do you think of this ?