Skip to content

feat: document -elem and -attr CSP directives#14196

Open
ematipico wants to merge 4 commits into
mainfrom
feat/docs-csp-elem-attrs
Open

feat: document -elem and -attr CSP directives#14196
ematipico wants to merge 4 commits into
mainfrom
feat/docs-csp-elem-attrs

Conversation

@ematipico

@ematipico ematipico commented Jul 2, 2026

Copy link
Copy Markdown
Member

Description (required)

This PR documents new APIs for CSP.

For Astro version: 7.1.0. See astro PR #17214.

@ematipico ematipico added merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day. labels Jul 2, 2026
@astrobot-houston

astrobot-houston commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Lunaria Status Overview

🌕 This pull request will trigger status changes.

Learn more

By default, every PR changing files present in the Lunaria configuration's files property will be considered and trigger status changes accordingly.

You can change this by adding one of the keywords present in the ignoreKeywords property in your Lunaria configuration file in the PR's title (ignoring all files) or by including a tracker directive in the merged commit's description.

Tracked Files

File Note
en/reference/api-reference.mdx Source changed, localizations will be marked as outdated.
en/reference/integrations-reference.mdx Source changed, localizations will be marked as outdated.
Warnings reference
Icon Description
🔄️ The source for this localization has been updated since the creation of this pull request, make sure all changes in the source have been applied.

@github-actions

github-actions Bot commented Jul 2, 2026

Copy link
Copy Markdown

Preview deployment

✅ Deployment complete!

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I left a few suggestions, mostly around `kind`: `'element'` because I think it might be confusing. My mind wants to correct this to kind: 'element'. So, it might be helpful to work around this.

Otherwise, this looks good to me. I was a bit scare by the big caution but I guess this is kinda expected for a tricky feature!

Comment thread src/content/docs/en/reference/api-reference.mdx Outdated
>
```

<p><Since v="7.1.0" /></p>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, nice catch. I forgot about this pattern when I answered on Discord. I think it makes sense now that I have the content right in front of me!

Comment thread src/content/docs/en/reference/api-reference.mdx Outdated
Comment thread src/content/docs/en/reference/api-reference.mdx Outdated
Comment thread src/content/docs/en/reference/api-reference.mdx Outdated
Comment thread src/content/docs/en/reference/api-reference.mdx Outdated
Comment thread src/content/docs/en/reference/integrations-reference.mdx Outdated
Comment thread src/content/docs/en/reference/integrations-reference.mdx Outdated
@ArmandPhilippot ArmandPhilippot added this to the 7.1 milestone Jul 2, 2026
ematipico and others added 2 commits July 3, 2026 06:41
Co-authored-by: Armand Philippot <git@armand.philippot.eu>
Co-authored-by: Armand Philippot <git@armand.philippot.eu>

@ArmandPhilippot ArmandPhilippot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the update, LGTM!

@yanthomasdev yanthomasdev left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a small nit but then LGTM

Comment thread src/content/docs/en/reference/api-reference.mdx Outdated
Co-authored-by: Yan <61414485+yanthomasdev@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-on-release Don't merge this before the feature is released! (MQ=approved but WAIT for feature release!) minor-release For the next minor release; in the milestone, "merge queue" = approved for merging on release day.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants