Prevent spurious full-reload on first browser visit after astro dev start#17286
Open
astrobot-houston wants to merge 1 commit into
Open
Prevent spurious full-reload on first browser visit after astro dev start#17286astrobot-houston wants to merge 1 commit into
astro dev start#17286astrobot-houston wants to merge 1 commit into
Conversation
…rver start (#17283)\n\nThe `invalidateDataStore` function in the content virtual mod plugin was\nsending a `full-reload` signal to the client HMR channel during the\n`buildStart` hook. Since no browser had loaded content yet at startup,\nthis queued reload was delivered to the first connecting client, causing\nan immediate page reload.\n\nAdd a `notifyClient` option to `invalidateDataStore` and pass\n`{ notifyClient: false }` from `buildStart` to skip the client reload\nduring initial startup while preserving the module invalidation needed\nto avoid the data store race condition (PR #12938)."
🦋 Changeset detectedLatest commit: f092236 The changes in this PR will be included in the next version bump. This PR includes changesets to release 395 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #17283
Changes
astro devstarts no longer receives an immediate, unprompted full-reload. Previously,invalidateDataStore()unconditionally sent afull-reloadHMR signal during thebuildStarthook — before any client connected — causing the signal to queue and fire the moment the first WebSocket client arrived.notifyClientoption toinvalidateDataStore()(defaulttrue). ThebuildStartcall now passes{ notifyClient: false }, preserving the module invalidation that prevents the content layer race condition (Empty content collection when dev is first run #12866) while skipping the client reload during startup.Testing
packages/astro/test/units/content-layer/content-virtual-mod.test.ts— verifies thatbuildStartinvalidates the data store module but does not send afull-reloadto the client HMR channel.Docs