Forward Wrangler config vars to astro:env#17275
Draft
matthewp wants to merge 1 commit into
Draft
Conversation
🦋 Changeset detectedLatest commit: 389dd27 The changes in this PR will be included in the next version bump. This PR includes changesets to release 40 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16790
Changes
astro:envpublic variables defined undervarsin a Wrangler config (wrangler.toml/.json/.jsonc) now resolve when imported fromastro:env/clientandastro:env/server. Previously only.dev.varswas loaded into the environment, so public vars were inlined asundefinedat build time (onlygetSecretworked).varsvia wrangler'sunstable_readConfiginastro:config:doneand assigns them toprocess.env, respectingCLOUDFLARE_ENV. Using wrangler's own reader covers TOML/JSON/JSONC and does the same env merging wrangler does at runtime..dev.varsis loaded afterwards so it still takes precedence.Testing
process.env.API_URL/process.env.PORToverrides fromastro-envSSR tests. Those overrides were masking the bug; the tests now rely on the adapter loadingvarsfrom the fixture'swrangler.jsonc, exercising the real code path for both build and dev.Docs
astro:envbehavior.