Skip to content

Fix flaky "below the fold" dev-toolbar perf audit e2e test #17192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eldardada wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −0
Open

Fix flaky "below the fold" dev-toolbar perf audit e2e test #17192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions packages/astro/e2e/dev-toolbar-audits.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,13 @@ test.describe('Dev Toolbar - Audits', () => {
}) => {
await page.goto(astro.resolveUrl('/audits-perf-absolute'));

// The audit gates highlight creation on the image's `load` event, so run it
// only after the image has finished loading. Otherwise a slow image load on CI
// can outlast the assertion timeout and intermittently report 0 highlights.
await expect(page.locator('img[alt="A walrus"]')).toHaveJSProperty('complete', true, {
timeout: 15_000,
});

const toolbar = page.locator('astro-dev-toolbar');
const appButton = toolbar.locator('button[data-app-id="astro:audit"]');
await appButton.click();
Expand Down
Loading