Skip to content

Collaborate nulleq tests#1

Open
yy782 wants to merge 3 commits into
windtalker:support_nulleqfrom
yy782:collaborate-nulleq-tests
Open

Collaborate nulleq tests#1
yy782 wants to merge 3 commits into
windtalker:support_nulleqfrom
yy782:collaborate-nulleq-tests

Conversation

@yy782

@yy782 yy782 commented Jul 4, 2026

Copy link
Copy Markdown

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:
This PR ports the test coverage from the closed PR pingcap#10954 to the support_nulleq branch of pingcap#10946, supplementing the core implementation with broader test cases.

What is changed and how it works?

  • Port type-combination tests from gtest_nulleq.cpp (updated to use tidbNullEQ function name)
  • Port minmax index tests from gtest_dm_minmax_index.cpp
  • Port fullstack end-to-end tests from nulleq.test
  • All tests have been verified to pass locally based on Support TiDB NullEQ pushdown pingcap/tiflash#10946

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

None

yy782 added 3 commits July 4, 2026 06:30
- Add NullEQ function integration test in tests/fullstack-test/expr/
- Test covers basic NullEQ usage with NULL values and non-NULL comparisons
- Tests nulleq(a, Null), nulleq(b, null), nulleq(a, 1), nulleq(b, 1) scenarios

Signed-off-by: yy <736262857@qq.com>
- Add unit tests for NullEQ (tidbNullEQ) function covering various data types

Signed-off-by: yy <736262857@qq.com>
- Add generateNullEqualOperator helper function to create NullEqual RSOperator for various data types
- Add MinMaxIndexTest.NullEqual test case to verify NullEqual RS Filter behavior

Signed-off-by: yy <736262857@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant